Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data to user details page #127019

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Add data to user details page #127019

merged 2 commits into from
Mar 10, 2022

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Mar 7, 2022 •
edited
Loading

issue: #126769

Summary

Add user overview information to user details page
Screenshot 2022-03-08 at 12 25 46

Checklist

Delete any items that are not applicable to this PR.

@machadoum machadoum force-pushed the siem-explore-issue-126769 branch from a9a7dd7 to db144e0 Compare March 7, 2022 14:31
@machadoum machadoum added enhancement New value added to drive a business result v8.2.0 release_note:feature Makes this part of the condensed release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 7, 2022
@machadoum machadoum force-pushed the siem-explore-issue-126769 branch 3 times, most recently from d17ef3f to 9e81c28 Compare March 8, 2022 12:22
@machadoum machadoum marked this pull request as ready for review March 8, 2022 12:30
@machadoum machadoum requested a review from a team as a code owner March 8, 2022 12:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@YulNaumenko YulNaumenko self-requested a review March 8, 2022 16:52
angorayc
angorayc reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pablo, all looks good, just some minor questions.

When I was browsing the page, I found some other questions on users page nothing to do with this pr:

  1. The search result in the search doesn't seem to have the same structure as other pages:

e.g. hosts page: it shows the default tab as Hosts and no additional result for Hosts / all
Screenshot 2022-03-09 at 18 29 34

Users page has an additional result for Users / all
Screenshot 2022-03-09 at 18 29 57

  1. The inspect button is disable on Users by risk table, I would suggest hiding it if the query is not available.
  2. There is an underline for text in the Users by risk dropdown but it's not a link, is it intended?
    Screenshot 2022-03-09 at 18 49 40

@machadoum
Copy link
Member Author

machadoum commented Mar 10, 2022 •
edited
Loading

There is an underline for text in the Users by risk dropdown but it's not a link, is it intended?

I think that the underlining is the standard behaviour of this EUI component. @stephmilovic, Could you confirm that?

@machadoum
Copy link
Member Author

machadoum commented Mar 10, 2022 •
edited
Loading

  • The inspect button is disable on Users by risk table, I would suggest hiding it if the query is not available.

It sounds like a reasonable idea, but I don't control this button visibility. Furthermore, the logic is inside the inspect button, so if I make it 'hidden', it would affect every Inspect button in the APP. Could we validate it with a designer first and implement the new behavior on another PR?

The code is here:

kibana/x-pack/plugins/security_solution/public/common/components/inspect/index.tsx

Line 112 in bad98b6

const isButtonDisabled = useMemo(

@machadoum
Copy link
Member Author

There is an underline for text in the Users by risk dropdown but it's not a link, is it intended?

I think that the underlining is the standard behaviour of this EUI component. @stephmilovic, Could you confirm that?

It also has an underline in the docs: https://elastic.github.io/eui/#/forms/filter-group

@machadoum machadoum force-pushed the siem-explore-issue-126769 branch from ce87ff6 to 551cfd4 Compare March 10, 2022 09:35
@machadoum machadoum self-assigned this Mar 10, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Security Solution Tests / risk tab "before all" hook for "renders risk tab"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2902 2907 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB +7.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 245.1KB 245.6KB +519.0B

History

  • 💚 Build #28356 succeeded 9e81c282008ef8e4da3f2c0334bdca49c9cfbb6b
  • 💚 Build #28285 succeeded d17ef3ff1da2f5637d3122c27b5ff9ea340b879e
  • 💔 Build #28063 failed 113f696c5f18e97069082b89c45f4585153d8c56
  • 💔 Build #28020 failed db144e028117be896d384cd9d6b70956bfa92a56
  • 💔 Build #27977 failed a9a7dd7e2d4bf3fa1645cdc87b20d3467e3349ac

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit ddc7092 into elastic:main Mar 10, 2022
@kibanamachine
Copy link
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 127019

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 10, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into screenshotting/…
6cb4725 
…move-pdf-generation-to-screenshotting

* 'main' of github.com:elastic/kibana: (62 commits)
  [Lens] Drop partial buckets option (elastic#127153)
  chore(NA): remove unused translation xpack.ml.management.jobsSpacesList.objectNoun from fr-FR (elastic#127457)
  Add data to user details page (elastic#127019)
  [Fleet] Make upload and registry package info consistent (elastic#126915)
  [Reporting] Capture browser errors (elastic#127135)
  Initial readme commit with some stub articles (elastic#127420)
  skip flaky suite (elastic#121482)
  skip flaky suite (elastic#127416)
  Tests to ensure Kibana is handling multi-space import of saved objects correctly (elastic#127229)
  [Aggs] remove toAngularJson (elastic#127267)
  [i18n] Integrate 8.2.0 Translations (elastic#127309)
  [Security Solution] [Endpoint] Creates generic policy tab artifact component to be used for all of our artifacts (elastic#126685)
  [Kibana React] Fix Page Template `solutionNav` propagation (elastic#127140)
  [Cases] Export getRelatedCases API from cases client (elastic#127065)
  [Cloud Posture]add support for sorting benchmark page (elastic#126983)
  [User experience] Fix filters for the app (elastic#127295)
  [Fleet] Fix timeserie dimension mapping (elastic#127328)
  [data view mgmt] fix data view name wrap (elastic#127319)
  [kbn/optimizer] extract string diffing logic (elastic#127394)
  [ResponseOps] Add pagination and sorting to the alerts search strategy (elastic#126813)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/common/errors.ts
#	x-pack/plugins/screenshotting/common/index.ts
#	x-pack/plugins/screenshotting/server/screenshots/observable.ts
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 14, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

10 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127019 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Mar 30, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

@YulNaumenko YulNaumenko Awaiting requested review from YulNaumenko

Assignees

@machadoum machadoum

Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting enhancement New value added to drive a business result release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@machadoum @elasticmachine @kibana-ci @kibanamachine @angorayc @spalger