-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified search] Create unified search plugin #127651
[Unified search] Create unified search plugin #127651
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
src/plugins/data/public/ui/filter_bar/filter_editor/lib/filter_label.test.tsx
Show resolved
Hide resolved
x-pack/plugins/osquery/cypress/integration/superuser/packs.spec.ts
Outdated
Show resolved
Hide resolved
src/plugins/unified_search/public/typeahead/suggestions_component.tsx
Outdated
Show resolved
Hide resolved
144f5ad
to
65fd06b
Compare
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable Observability changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML changes LGTM (code and tested locally).
…nlatipov/kibana into issue-move-UI-to-unified_search
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
@elastic/kibana-design, @elastic/security-onboarding-and-lifecycle-mgt, @elastic/security-solution we need your 👀 here. Please review |
…nlatipov/kibana into issue-move-UI-to-unified_search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins/security_solution
changes look good. I have a few changes that I'd like to be made.
x-pack/plugins/security_solution/public/common/mock/endpoint/dependencies_start_mock.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved SCSS files; updated import paths.
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
Unreferenced deprecated APIs
History
To update your PR or re-run it, just comment with: cc @nlatipov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @nlatipov
Summary
This PR is solves part of Issue: #127243
Motivation:
As a first step we want to move the ui folder of the
data
plugin to a new plugin,unified_search
. No extra functionality is going to be added (or cleanups or improvements). All the applications that are using the SearchBar should be updated to import it from the new plugin.What was done:
unified_search
plugin was created;data/plugin/ui
folder was moved intounified_search
;Data Plugin
runtime contract toUnifiedSearch Plugin
Static
andRuntime
imports were updateddata/plugin/actions/apply_filter_action.ts
file was moved intounified_search
;