Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert pr/126320 #128096

Merged
merged 5 commits into from
Mar 21, 2022
Merged

Revert pr/126320 #128096

merged 5 commits into from
Mar 21, 2022

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Mar 18, 2022 •
edited
Loading

This reverts commit 6e11bea.

This is causing a ~200mb increase in idle memory usage. Investigation at #128061

@jbudz jbudz mentioned this pull request Mar 18, 2022
Closed
@jbudz jbudz marked this pull request as ready for review March 21, 2022 17:55
@jbudz jbudz requested a review from a team as a code owner March 21, 2022 17:55
@jbudz jbudz changed the title [cloud] Testing memory usage without pr/126320 Revert pr/126320 Mar 21, 2022
@jbudz jbudz added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.2.0 labels Mar 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jbudz jbudz added skip-ci release_note:skip Skip the PR/issue when compiling release notes and removed skip-ci labels Mar 21, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pgayvallet
pgayvallet approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that, once again, one does not simply touch the observable chain of the status service.

@jbudz jbudz merged commit a1085f4 into elastic:main Mar 21, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128096 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 23, 2022
@jbudz jbudz added the backport:skip This commit does not require backporting label Mar 23, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @elasticmachine @kibana-ci @kibanamachine @pgayvallet