-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified search] Improves the current filter/search experience #128401
Commits on Mar 21, 2022
-
[Unified search] Moves dataview picker to the search bar (#126560)
* [Unified search] Moves dataview picker to the search bar * alter texts * Remove unused file * [ChangeDataView] Design cleanup * Fix services mock failure * Show newly created datavuew on the list * Keep dataview picker in discover in mobile view * Cleanup * Cleanup translations * Fix some discover FTs * Fix management FTs * More test fixes * Added a dismissible tour * Pulled the selectabl list into a new component … for reuse Called `DataViewsList`. I then changed Lens’ config panel’s own EuiSelectableList to use this new component instead. *Didn’t do any test updates* * Fix broken jest test * Use the same picker component on Discover mobile view * Apply some CI fixes * Fix more functional tests * More FTs fixes * Close the tour popover for lens tests * More FTs fixes * Fix lens FTs * Using new `styles.ts` pattern for custom styles and allowing for `fullWidth` buttons * Better tour text and i18n * Update copy * No exclamation point * Cleanup * Fixes on discover tests * Fixes on Lens Fts - create runtime fields * Fixes on edit permission of add field in discover and some FTs fixes * Further Fts fixes * More FTs fixes * Made tour opt-in with `showNewMenuTour` * Refactor the OSS FTs to change less files * Further cleanup on the FTs * Remove unecessary action * Fix dataview creation bug * Add a unit test to the new component * More fixes * Fix OSS a11y tests * Adds another unit test for Lens permissions * Make a change to stabilize the tests * Clear flyout prop as it is not used anymore * Deisgn fixes for mobile view * Address PR comments WIP * Update the layrpanl dataview list when a new dataview is created Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0271e79 - Browse repository at this point
Copy the full SHA 0271e79View commit details
Commits on Mar 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a658848 - Browse repository at this point
Copy the full SHA a658848View commit details
Commits on Mar 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 391b3b5 - Browse repository at this point
Copy the full SHA 391b3b5View commit details
Commits on Mar 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ca79be1 - Browse repository at this point
Copy the full SHA ca79be1View commit details
Commits on Mar 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ac9bf8e - Browse repository at this point
Copy the full SHA ac9bf8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78b52a0 - Browse repository at this point
Copy the full SHA 78b52a0View commit details
Commits on Mar 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for aacc187 - Browse repository at this point
Copy the full SHA aacc187View commit details
Commits on Mar 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e7498fa - Browse repository at this point
Copy the full SHA e7498faView commit details
Commits on Apr 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d67380c - Browse repository at this point
Copy the full SHA d67380cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 110067c - Browse repository at this point
Copy the full SHA 110067cView commit details
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 225ce94 - Browse repository at this point
Copy the full SHA 225ce94View commit details
Commits on Apr 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4811ecd - Browse repository at this point
Copy the full SHA 4811ecdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9e6696 - Browse repository at this point
Copy the full SHA f9e6696View commit details
Commits on Apr 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 882f862 - Browse repository at this point
Copy the full SHA 882f862View commit details
Commits on Apr 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 24fafbb - Browse repository at this point
Copy the full SHA 24fafbbView commit details
Commits on Apr 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 78c151e - Browse repository at this point
Copy the full SHA 78c151eView commit details -
[Unified search] Redesign search bar (#126566)
* [Unified search] Redesign search bar * Changes to the saved queries design * Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper` * [Security Solution] Removing overrides of `.globaQueryBar` * Cleanup of `.globalQueryBar` styles and variants * General layout fixes/adjustments * More general layout fixes and better defaults * Enable Clear all button if saved query is applied * Clear should be enabled if searched query is applied but not the save as new * fix some bugs on enabling and disabling the menu options * [design] Working on Load Filter set menu * Indicate selection even before the user clicks apply * prettify the time text * Add delete saved qquery confirmation modal * Some cleaning up * Fix the manage saved queries link * Enable load filter set if saved query is created for the first time * Some fixes on linting and on translations * Clanup scss * Make some fixes * Fix navigatation unit test * Fix translations check * Fix rest jest tests * Fix some functional tests * Fix checks * Fixes the appearance of the searchbar components depending on the flags * Fix OSS tests * Fixes on tests and query bar logic * Fix the OSS ally tests * Fix graph and lens KQL bar display problems, apply saveQuery flag correctly * Fix more tests * Fix security solution test * Undo tweaks for graph * Better fix for Graph - Emulate new look, not old - Uses same context menu panel as the new one - Provides the same button type (filter button) * Fix checks and jest test * Further fixes * Fix language switcher test * Hopefully fixes the rest of the solution tests * Cleanup * Fixes on maps filtering * Fix Discover padding * [Discover] Added New Field button to bottom of fields list * Simple responsive behavior * Quick filter updates * CI fixes * area-label fix * 18n translate the add filed btn in discover * Fix lens functional test * fix functional tests * Refactor and add unit test for the add filter button * Add unit test to the saved management list component * Stabilize lens test * Second try to solve the flakiness * Fix panels depending on the flags * Fix jest tests * Fix double menu when only the queryInput is on * Add storybook for the different layouts of the unified search bar * Fix ci checks * Removee hooks comment * Fix flakiness * Fix problem with lens dataview change * Fix checks * Ensure that the query is submitted * Fixes oon CI * Fixes flakiness * Fix checks CI * Update texts * Cleanup * Fix unskipped funtional test * Fix FT * Update src/plugins/unified_search/public/saved_query_form/save_query_form.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Fix eslint * Fix checks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7ad845a - Browse repository at this point
Copy the full SHA 7ad845aView commit details
Commits on Apr 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 182b8cb - Browse repository at this point
Copy the full SHA 182b8cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53e7877 - Browse repository at this point
Copy the full SHA 53e7877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6603b29 - Browse repository at this point
Copy the full SHA 6603b29View commit details
Commits on Apr 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3d8c255 - Browse repository at this point
Copy the full SHA 3d8c255View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93a2184 - Browse repository at this point
Copy the full SHA 93a2184View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0599d9d - Browse repository at this point
Copy the full SHA 0599d9dView commit details
Commits on Apr 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8e0167c - Browse repository at this point
Copy the full SHA 8e0167cView commit details -
[Unified search] Further enhancements (#129877)
* [Unified search] Redesign search bar * Changes to the saved queries design * Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper` * [Security Solution] Removing overrides of `.globaQueryBar` * Cleanup of `.globalQueryBar` styles and variants * General layout fixes/adjustments * More general layout fixes and better defaults * Enable Clear all button if saved query is applied * Clear should be enabled if searched query is applied but not the save as new * fix some bugs on enabling and disabling the menu options * [design] Working on Load Filter set menu * Indicate selection even before the user clicks apply * prettify the time text * Add delete saved qquery confirmation modal * Some cleaning up * Fix the manage saved queries link * Enable load filter set if saved query is created for the first time * Some fixes on linting and on translations * Clanup scss * Make some fixes * Fix navigatation unit test * Fix translations check * Fix rest jest tests * Fix some functional tests * Fix checks * Fixes the appearance of the searchbar components depending on the flags * Fix OSS tests * Fixes on tests and query bar logic * Fix the OSS ally tests * Fix graph and lens KQL bar display problems, apply saveQuery flag correctly * Fix more tests * Fix security solution test * Undo tweaks for graph * Better fix for Graph - Emulate new look, not old - Uses same context menu panel as the new one - Provides the same button type (filter button) * Fix checks and jest test * Further fixes * Fix language switcher test * Hopefully fixes the rest of the solution tests * Cleanup * Fixes on maps filtering * Fix Discover padding * [Discover] Added New Field button to bottom of fields list * Simple responsive behavior * Quick filter updates * CI fixes * area-label fix * 18n translate the add filed btn in discover * Fix lens functional test * fix functional tests * Refactor and add unit test for the add filter button * Add unit test to the saved management list component * Stabilize lens test * Second try to solve the flakiness * Fix panels depending on the flags * Fix jest tests * Fix double menu when only the queryInput is on * Add storybook for the different layouts of the unified search bar * Fix ci checks * Removee hooks comment * Fix flakiness * Fix problem with lens dataview change * Fix checks * Ensure that the query is submitted * Fixes oon CI * Fixes flakiness * Fix checks CI * Update texts * Cleanup * Fix unskipped funtional test * Fix FT * Fixes filter bar responsiveness * Add filter button option to the main menu * Filter form design pass - Added tooltip around “Add filter” icon button - Fixed padding - Stubbed in “Add” vs “Edit” labels * Query menu icon button tooltip * ‘Update’ not ‘Edit’ button label * Apply different strings for adding filter mode vs edit * Hide Manage SO link if the user donesnt have the permissions * Fix the wrapping of the badges and datepicker badge * Minor props naming fix * Fix checks * Fix mobile * Cleanup * Fix checks * Faux button group * Changes on the search input placeholder * Fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3ef6fb1 - Browse repository at this point
Copy the full SHA 3ef6fb1View commit details
Commits on Apr 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 232d885 - Browse repository at this point
Copy the full SHA 232d885View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ae9b70 - Browse repository at this point
Copy the full SHA 0ae9b70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e14bcc - Browse repository at this point
Copy the full SHA 1e14bccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a753b6 - Browse repository at this point
Copy the full SHA 1a753b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f8ea11 - Browse repository at this point
Copy the full SHA 7f8ea11View commit details -
Filter bar / items: Reduce to only necessary wrappers and styles
- Switch to Emotion for styling - Rename `FilterBadgesWrapper` to `FilterItems` - Move `FilterItems` and `FilterItem` so own folder `filter_item/` # Conflicts: # src/plugins/unified_search/public/filter_bar/filter_bar.tsx # src/plugins/unified_search/public/filter_bar/filter_editor/lib/filter_label.tsx # src/plugins/unified_search/public/filter_bar/filter_item/filter_item.tsx # src/plugins/unified_search/public/filter_bar/filter_item/filter_items.tsx # src/plugins/unified_search/public/filter_bar/filter_view/index.tsx # src/plugins/unified_search/public/query_string_input/filter_editor_wrapper.tsx # src/plugins/unified_search/public/search_bar/search_bar.tsx
cchaos committedApr 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 37d2f24 - Browse repository at this point
Copy the full SHA 37d2f24View commit details -
Fix styles by removing styled-components
Also added prop `afterQueryBar` to signify that it needs the top margin # Conflicts: # packages/kbn-babel-preset/styled_components_files.js
cchaos committedApr 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 3c8985f - Browse repository at this point
Copy the full SHA 3c8985fView commit details -
Refactor
SearchBar
andQueryBarTopRow
a bit- Added `showSubmitButton` to explicitely hide the submit button (defaults to true) - SearchBar always renders the `QueryBarTopRow` which now fully controls visibility of the pieces - Renamed class with new `uni` prefix - Tried and failed to use Emotion
cchaos committedApr 21, 2022 Configuration menu - View commit details
-
Copy full SHA for cfbd22a - Browse repository at this point
Copy the full SHA cfbd22aView commit details -
# Conflicts: # x-pack/plugins/security_solution/public/common/components/query_bar/index.tsx
cchaos committedApr 21, 2022 Configuration menu - View commit details
-
Copy full SHA for f304d53 - Browse repository at this point
Copy the full SHA f304d53View commit details -
cchaos committed
Apr 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 91264f4 - Browse repository at this point
Copy the full SHA 91264f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b2ed98 - Browse repository at this point
Copy the full SHA 7b2ed98View commit details -
Attaches filter menu when no add button and better dropdown styles
cchaos committedApr 21, 2022 Configuration menu - View commit details
-
Copy full SHA for ee0413b - Browse repository at this point
Copy the full SHA ee0413bView commit details
Commits on Apr 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d8006ad - Browse repository at this point
Copy the full SHA d8006adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a0c7cc - Browse repository at this point
Copy the full SHA 9a0c7ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for d89f3ba - Browse repository at this point
Copy the full SHA d89f3baView commit details
Commits on Apr 25, 2022
-
Fix Graph by creating reusable
KibanaFilterButtonGroup
cchaos committedApr 25, 2022 Configuration menu - View commit details
-
Copy full SHA for f7ee3c4 - Browse repository at this point
Copy the full SHA f7ee3c4View commit details
Commits on Apr 26, 2022
-
Use EuiTheme for SearchBar styles
Updated `displayStyle` for Lens & Discover
cchaos committedApr 26, 2022 Configuration menu - View commit details
-
Copy full SHA for b9b19f8 - Browse repository at this point
Copy the full SHA b9b19f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6867bea - Browse repository at this point
Copy the full SHA 6867beaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bb1065 - Browse repository at this point
Copy the full SHA 1bb1065View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7074fc1 - Browse repository at this point
Copy the full SHA 7074fc1View commit details
Commits on Apr 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 340e0d4 - Browse repository at this point
Copy the full SHA 340e0d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40bb170 - Browse repository at this point
Copy the full SHA 40bb170View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54f868c - Browse repository at this point
Copy the full SHA 54f868cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f9d6e2 - Browse repository at this point
Copy the full SHA 8f9d6e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b61d61e - Browse repository at this point
Copy the full SHA b61d61eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dbf763 - Browse repository at this point
Copy the full SHA 5dbf763View commit details -
[Submit button] Changed to EuiSuperUpdateButton
- Quickly adds tooltip content and filled state for more prominence when dirty - Fixed 18n
cchaos committedApr 28, 2022 Configuration menu - View commit details
-
Copy full SHA for c278f67 - Browse repository at this point
Copy the full SHA c278f67View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0d3539 - Browse repository at this point
Copy the full SHA a0d3539View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1adaee6 - Browse repository at this point
Copy the full SHA 1adaee6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29a09c6 - Browse repository at this point
Copy the full SHA 29a09c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 160bd76 - Browse repository at this point
Copy the full SHA 160bd76View commit details
Commits on Apr 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 973ad0e - Browse repository at this point
Copy the full SHA 973ad0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6843fef - Browse repository at this point
Copy the full SHA 6843fefView commit details
Commits on May 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e814fa1 - Browse repository at this point
Copy the full SHA e814fa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b76c8f4 - Browse repository at this point
Copy the full SHA b76c8f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc0d302 - Browse repository at this point
Copy the full SHA bc0d302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 504d706 - Browse repository at this point
Copy the full SHA 504d706View commit details
Commits on May 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0a72bc1 - Browse repository at this point
Copy the full SHA 0a72bc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e86baaf - Browse repository at this point
Copy the full SHA e86baafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10b616a - Browse repository at this point
Copy the full SHA 10b616aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42ae00c - Browse repository at this point
Copy the full SHA 42ae00cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 108f0ad - Browse repository at this point
Copy the full SHA 108f0adView commit details -
Configuration menu - View commit details
-
Copy full SHA for eca5885 - Browse repository at this point
Copy the full SHA eca5885View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9f03b1 - Browse repository at this point
Copy the full SHA e9f03b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92f9ad0 - Browse repository at this point
Copy the full SHA 92f9ad0View commit details
Commits on May 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e398ced - Browse repository at this point
Copy the full SHA e398cedView commit details -
Configuration menu - View commit details
-
Copy full SHA for c865ad0 - Browse repository at this point
Copy the full SHA c865ad0View commit details
Commits on May 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 54d2949 - Browse repository at this point
Copy the full SHA 54d2949View commit details