Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified search] Improves the current filter/search experience #128401

Merged
merged 73 commits into from
May 6, 2022

Commits on Mar 21, 2022

  1. [Unified search] Moves dataview picker to the search bar (#126560)

    * [Unified search] Moves dataview picker to the search bar
    
    * alter texts
    
    * Remove unused file
    
    * [ChangeDataView] Design cleanup
    
    * Fix services mock failure
    
    * Show newly created datavuew on the list
    
    * Keep dataview picker in discover in mobile view
    
    * Cleanup
    
    * Cleanup translations
    
    * Fix some discover FTs
    
    * Fix management FTs
    
    * More test fixes
    
    * Added a dismissible tour
    
    * Pulled the selectabl list into a new component
    
    … for reuse
    
    Called `DataViewsList`. I then changed Lens’ config panel’s own EuiSelectableList to use this new component instead.
    
    *Didn’t do any test updates*
    
    * Fix broken jest test
    
    * Use the same picker component on Discover mobile view
    
    * Apply some CI fixes
    
    * Fix more functional tests
    
    * More FTs fixes
    
    * Close the tour popover for lens tests
    
    * More FTs fixes
    
    * Fix lens FTs
    
    * Using new `styles.ts` pattern for custom styles and allowing for `fullWidth` buttons
    
    * Better tour text and i18n
    
    * Update copy
    
    * No exclamation point
    
    * Cleanup
    
    * Fixes on discover tests
    
    * Fixes on Lens Fts - create runtime fields
    
    * Fixes on edit permission of add field in discover and some FTs fixes
    
    * Further Fts fixes
    
    * More FTs fixes
    
    * Made tour opt-in with `showNewMenuTour`
    
    * Refactor the OSS FTs to change less files
    
    * Further cleanup on the FTs
    
    * Remove unecessary action
    
    * Fix dataview creation bug
    
    * Add a unit test to the new component
    
    * More fixes
    
    * Fix OSS a11y tests
    
    * Adds another unit test for Lens permissions
    
    * Make a change to stabilize the tests
    
    * Clear flyout prop as it is not used anymore
    
    * Deisgn fixes for mobile view
    
    * Address PR comments WIP
    
    * Update the layrpanl dataview list when a new dataview is created
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: cchaos <caroline.horn@elastic.co>
    Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
    4 people authored Mar 21, 2022
    Configuration menu
    Copy the full SHA
    0271e79 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Configuration menu
    Copy the full SHA
    a658848 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Configuration menu
    Copy the full SHA
    391b3b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Configuration menu
    Copy the full SHA
    ca79be1 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Configuration menu
    Copy the full SHA
    ac9bf8e View commit details
    Browse the repository at this point in the history
  2. fix test

    stratoula committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    78b52a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Configuration menu
    Copy the full SHA
    aacc187 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Configuration menu
    Copy the full SHA
    e7498fa View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. Configuration menu
    Copy the full SHA
    d67380c View commit details
    Browse the repository at this point in the history
  2. Fix CI

    stratoula committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    110067c View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Configuration menu
    Copy the full SHA
    225ce94 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Configuration menu
    Copy the full SHA
    4811ecd View commit details
    Browse the repository at this point in the history
  2. Fix i18n checks

    stratoula committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    f9e6696 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Configuration menu
    Copy the full SHA
    882f862 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Configuration menu
    Copy the full SHA
    24fafbb View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Configuration menu
    Copy the full SHA
    78c151e View commit details
    Browse the repository at this point in the history
  2. [Unified search] Redesign search bar (#126566)

    * [Unified search] Redesign search bar
    
    * Changes to the saved queries design
    
    * Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper`
    
    * [Security Solution] Removing overrides of `.globaQueryBar`
    
    * Cleanup of `.globalQueryBar` styles and variants
    
    * General layout fixes/adjustments
    
    * More general layout fixes and better defaults
    
    * Enable Clear all button if saved query is applied
    
    * Clear should be enabled if searched query is applied but not the save as new
    
    * fix some bugs on enabling and disabling the menu options
    
    * [design] Working on Load Filter set menu
    
    * Indicate selection even before the user clicks apply
    
    * prettify the time text
    
    * Add delete saved qquery confirmation modal
    
    * Some cleaning up
    
    * Fix the manage saved queries link
    
    * Enable load filter set if saved query is created for the first time
    
    * Some fixes on linting and on translations
    
    * Clanup scss
    
    * Make some fixes
    
    * Fix navigatation unit test
    
    * Fix translations check
    
    * Fix rest jest tests
    
    * Fix some functional tests
    
    * Fix checks
    
    * Fixes the appearance of the searchbar components depending on the flags
    
    * Fix OSS tests
    
    * Fixes on tests and query bar logic
    
    * Fix the OSS ally tests
    
    * Fix graph and lens KQL bar display problems, apply saveQuery flag correctly
    
    * Fix more tests
    
    * Fix security solution test
    
    * Undo tweaks for graph
    
    * Better fix for Graph
    
    - Emulate new look, not old
    - Uses same context menu panel as the new one
    - Provides the same button type (filter button)
    
    * Fix checks and jest test
    
    * Further fixes
    
    * Fix language switcher test
    
    * Hopefully fixes the rest of the solution tests
    
    * Cleanup
    
    * Fixes on maps filtering
    
    * Fix Discover padding
    
    * [Discover] Added New Field button to bottom of fields list
    
    * Simple responsive behavior
    
    * Quick filter updates
    
    * CI fixes
    
    * area-label fix
    
    * 18n translate the add filed btn in discover
    
    * Fix lens functional test
    
    * fix functional tests
    
    * Refactor and add unit test for the add filter button
    
    * Add unit test to the saved management list component
    
    * Stabilize lens test
    
    * Second try to solve the flakiness
    
    * Fix panels depending on the flags
    
    * Fix jest tests
    
    * Fix double menu when only the queryInput is on
    
    * Add storybook for the different layouts of the unified search bar
    
    * Fix ci checks
    
    * Removee hooks comment
    
    * Fix flakiness
    
    * Fix problem with lens dataview change
    
    * Fix checks
    
    * Ensure that the query is submitted
    
    * Fixes oon CI
    
    * Fixes flakiness
    
    * Fix checks CI
    
    * Update texts
    
    * Cleanup
    
    * Fix unskipped funtional test
    
    * Fix FT
    
    * Update src/plugins/unified_search/public/saved_query_form/save_query_form.tsx
    
    Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
    
    * Fix eslint
    
    * Fix checks
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: cchaos <caroline.horn@elastic.co>
    Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
    Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
    5 people authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    7ad845a View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Configuration menu
    Copy the full SHA
    182b8cb View commit details
    Browse the repository at this point in the history
  2. Fix jest

    stratoula committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    53e7877 View commit details
    Browse the repository at this point in the history
  3. Fix jest tests

    stratoula committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    6603b29 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. Merge with ES lint commit

    stratoula committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    3d8c255 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    93a2184 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0599d9d View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Configuration menu
    Copy the full SHA
    8e0167c View commit details
    Browse the repository at this point in the history
  2. [Unified search] Further enhancements (#129877)

    * [Unified search] Redesign search bar
    
    * Changes to the saved queries design
    
    * Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper`
    
    * [Security Solution] Removing overrides of `.globaQueryBar`
    
    * Cleanup of `.globalQueryBar` styles and variants
    
    * General layout fixes/adjustments
    
    * More general layout fixes and better defaults
    
    * Enable Clear all button if saved query is applied
    
    * Clear should be enabled if searched query is applied but not the save as new
    
    * fix some bugs on enabling and disabling the menu options
    
    * [design] Working on Load Filter set menu
    
    * Indicate selection even before the user clicks apply
    
    * prettify the time text
    
    * Add delete saved qquery confirmation modal
    
    * Some cleaning up
    
    * Fix the manage saved queries link
    
    * Enable load filter set if saved query is created for the first time
    
    * Some fixes on linting and on translations
    
    * Clanup scss
    
    * Make some fixes
    
    * Fix navigatation unit test
    
    * Fix translations check
    
    * Fix rest jest tests
    
    * Fix some functional tests
    
    * Fix checks
    
    * Fixes the appearance of the searchbar components depending on the flags
    
    * Fix OSS tests
    
    * Fixes on tests and query bar logic
    
    * Fix the OSS ally tests
    
    * Fix graph and lens KQL bar display problems, apply saveQuery flag correctly
    
    * Fix more tests
    
    * Fix security solution test
    
    * Undo tweaks for graph
    
    * Better fix for Graph
    
    - Emulate new look, not old
    - Uses same context menu panel as the new one
    - Provides the same button type (filter button)
    
    * Fix checks and jest test
    
    * Further fixes
    
    * Fix language switcher test
    
    * Hopefully fixes the rest of the solution tests
    
    * Cleanup
    
    * Fixes on maps filtering
    
    * Fix Discover padding
    
    * [Discover] Added New Field button to bottom of fields list
    
    * Simple responsive behavior
    
    * Quick filter updates
    
    * CI fixes
    
    * area-label fix
    
    * 18n translate the add filed btn in discover
    
    * Fix lens functional test
    
    * fix functional tests
    
    * Refactor and add unit test for the add filter button
    
    * Add unit test to the saved management list component
    
    * Stabilize lens test
    
    * Second try to solve the flakiness
    
    * Fix panels depending on the flags
    
    * Fix jest tests
    
    * Fix double menu when only the queryInput is on
    
    * Add storybook for the different layouts of the unified search bar
    
    * Fix ci checks
    
    * Removee hooks comment
    
    * Fix flakiness
    
    * Fix problem with lens dataview change
    
    * Fix checks
    
    * Ensure that the query is submitted
    
    * Fixes oon CI
    
    * Fixes flakiness
    
    * Fix checks CI
    
    * Update texts
    
    * Cleanup
    
    * Fix unskipped funtional test
    
    * Fix FT
    
    * Fixes filter bar responsiveness
    
    * Add filter button option to the main menu
    
    * Filter form design pass
    
    - Added tooltip around “Add filter” icon button
    - Fixed padding
    - Stubbed in “Add” vs “Edit” labels
    
    * Query menu icon button tooltip
    
    * ‘Update’ not ‘Edit’ button label
    
    * Apply different strings for adding filter mode vs edit
    
    * Hide Manage SO link if the user donesnt have the permissions
    
    * Fix the wrapping of the badges and datepicker badge
    
    * Minor props naming fix
    
    * Fix checks
    
    * Fix mobile
    
    * Cleanup
    
    * Fix checks
    
    * Faux button group
    
    * Changes on the search input placeholder
    
    * Fix CI
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: cchaos <caroline.horn@elastic.co>
    Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
    4 people authored Apr 20, 2022
    Configuration menu
    Copy the full SHA
    3ef6fb1 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Configuration menu
    Copy the full SHA
    232d885 View commit details
    Browse the repository at this point in the history
  2. Fix translations

    stratoula committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    0ae9b70 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1e14bcc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1a753b6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7f8ea11 View commit details
    Browse the repository at this point in the history
  6. Filter bar / items: Reduce to only necessary wrappers and styles

    - Switch to Emotion for styling
    - Rename `FilterBadgesWrapper` to `FilterItems`
    - Move `FilterItems` and `FilterItem` so own folder `filter_item/`
    
    # Conflicts:
    #	src/plugins/unified_search/public/filter_bar/filter_bar.tsx
    #	src/plugins/unified_search/public/filter_bar/filter_editor/lib/filter_label.tsx
    #	src/plugins/unified_search/public/filter_bar/filter_item/filter_item.tsx
    #	src/plugins/unified_search/public/filter_bar/filter_item/filter_items.tsx
    #	src/plugins/unified_search/public/filter_bar/filter_view/index.tsx
    #	src/plugins/unified_search/public/query_string_input/filter_editor_wrapper.tsx
    #	src/plugins/unified_search/public/search_bar/search_bar.tsx
    cchaos committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    37d2f24 View commit details
    Browse the repository at this point in the history
  7. Fix styles by removing styled-components

    Also added prop `afterQueryBar` to signify that it needs the top margin
    
    # Conflicts:
    #	packages/kbn-babel-preset/styled_components_files.js
    cchaos committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    3c8985f View commit details
    Browse the repository at this point in the history
  8. Refactor SearchBar and QueryBarTopRow a bit

    - Added `showSubmitButton` to explicitely hide the submit button (defaults to true)
    - SearchBar always renders the `QueryBarTopRow` which now fully controls visibility of the pieces
    - Renamed class with new `uni` prefix
    - Tried and failed to use Emotion
    cchaos committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    cfbd22a View commit details
    Browse the repository at this point in the history
  9. Update usages

    # Conflicts:
    #	x-pack/plugins/security_solution/public/common/components/query_bar/index.tsx
    cchaos committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    f304d53 View commit details
    Browse the repository at this point in the history
  10. Fix a test

    cchaos committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    91264f4 View commit details
    Browse the repository at this point in the history
  11. Fix jest test

    stratoula committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    7b2ed98 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ee0413b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. Fix lint errors

    stratoula committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d8006ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a0c7cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d89f3ba View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Configuration menu
    Copy the full SHA
    f7ee3c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Use EuiTheme for SearchBar styles

    Updated `displayStyle` for Lens & Discover
    cchaos committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    b9b19f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6867bea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1bb1065 View commit details
    Browse the repository at this point in the history
  4. Super nit comment

    stratoula committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    7074fc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Configuration menu
    Copy the full SHA
    340e0d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40bb170 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    54f868c View commit details
    Browse the repository at this point in the history
  4. Fix translations checks

    stratoula committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    8f9d6e2 View commit details
    Browse the repository at this point in the history
  5. Fix translations checks

    stratoula committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    b61d61e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5dbf763 View commit details
    Browse the repository at this point in the history
  7. [Submit button] Changed to EuiSuperUpdateButton

    - Quickly adds tooltip content and filled state for more prominence when dirty
    - Fixed 18n
    cchaos committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    c278f67 View commit details
    Browse the repository at this point in the history
  8. Fix tests

    stratoula committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    a0d3539 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1adaee6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    29a09c6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    160bd76 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Configuration menu
    Copy the full SHA
    973ad0e View commit details
    Browse the repository at this point in the history
  2. Fix tests

    stratoula committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    6843fef View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Configuration menu
    Copy the full SHA
    e814fa1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b76c8f4 View commit details
    Browse the repository at this point in the history
  3. Fix CI checks

    stratoula committed May 3, 2022
    Configuration menu
    Copy the full SHA
    bc0d302 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    504d706 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Address PR comments

    stratoula committed May 4, 2022
    Configuration menu
    Copy the full SHA
    0a72bc1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e86baaf View commit details
    Browse the repository at this point in the history
  3. Apply PR comments

    stratoula committed May 4, 2022
    Configuration menu
    Copy the full SHA
    10b616a View commit details
    Browse the repository at this point in the history
  4. Fix dataview picker glich

    stratoula committed May 4, 2022
    Configuration menu
    Copy the full SHA
    42ae00c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    108f0ad View commit details
    Browse the repository at this point in the history
  6. lovercase emotion function

    stratoula committed May 4, 2022
    Configuration menu
    Copy the full SHA
    eca5885 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e9f03b1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    92f9ad0 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Configuration menu
    Copy the full SHA
    e398ced View commit details
    Browse the repository at this point in the history
  2. Clean up

    stratoula committed May 5, 2022
    Configuration menu
    Copy the full SHA
    c865ad0 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Configuration menu
    Copy the full SHA
    54d2949 View commit details
    Browse the repository at this point in the history