Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Merge settings & mappings component template in @package #128498

Merged
merged 7 commits into from
Mar 29, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Mar 24, 2022

Summary

Resolve #128209

Mappings could depend on some other fields defined in template settings like analyzer for example. To avoid issues with missing settings, that PR merge @mappings and @settings component template in a new @package component template that contains both index template mapping and settings.

@nchaulet nchaulet added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 24, 2022
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.2.0 labels Mar 24, 2022
@nchaulet nchaulet self-assigned this Mar 24, 2022
@nchaulet nchaulet marked this pull request as ready for review March 24, 2022 15:58
@nchaulet nchaulet requested a review from a team as a code owner March 24, 2022 15:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang jen-huang added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Mar 24, 2022
@joshdover
Copy link
Contributor

I'm +1 on this change, but I'd like to do some extra testing on this before we merge. @hop-dev let's make sure we update the test instructions for the QA team on the mappings component issue.

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@ruflin
Copy link
Member

ruflin commented Mar 28, 2022

What is the migration path from old to new? At what stage will the change be applied?

@nchaulet
Copy link
Member Author

What is the migration path from old to new? At what stage will the change be applied?

This change will be applied when a package is upgraded or reinstalled. @hop-dev I think you make a change to do .fleet-global template in 8.2 right? if it's the case all the package will be reinstalled in 8.2 and everybody will get the change.

@hop-dev
Copy link
Contributor

hop-dev commented Mar 28, 2022

What is the migration path from old to new? At what stage will the change be applied?

This change will be applied when a package is upgraded or reinstalled. @hop-dev I think you make a change to do .fleet-global template in 8.2 right? if it's the case all the package will be reinstalled in 8.2 and everybody will get the change.

Yes thats right, it will be applied to every package on kibana startup

@ruflin
Copy link
Member

ruflin commented Mar 28, 2022

if it's the case all the package will be reinstalled

If a package is reinstalled, does it mean all data streams are rolled over or only the ones with a conflict?

@nchaulet
Copy link
Member Author

If a package is reinstalled, does it mean all data streams are rolled over or only the ones with a conflict?

Only one with conflict otherwise we just update the backing indices.

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did additional testing upgrading from 8.1 -> this branch and found no unexpected issues. My custom mappings in @custom templates were correctly applied after the upgrade.

@nchaulet nchaulet merged commit e906db2 into elastic:main Mar 29, 2022
@nchaulet nchaulet deleted the feature-merge-settings-mappings branch March 29, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Analyzer in index template settings are not working
8 participants