Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Show red color when overing the delete button in the cases table #128718

Merged
merged 2 commits into from
Mar 29, 2022
Merged

[Cases] Show red color when overing the delete button in the cases table #128718

merged 2 commits into from
Mar 29, 2022

Conversation

academo
Copy link
Contributor

@academo academo commented Mar 29, 2022

Summary

Fixes #128601
red-delete-cases

@academo academo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.2.0 labels Mar 29, 2022
@academo academo requested a review from a team as a code owner March 29, 2022 08:45
@academo academo self-assigned this Mar 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@academo academo enabled auto-merge (squash) March 29, 2022 08:50
@academo academo mentioned this pull request Mar 29, 2022
Closed
@cnasikas cnasikas added the bug Fixes for quality problems that affect the customer experience label Mar 29, 2022
peteharverson
peteharverson approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@academo academo merged commit 5fda6d5 into elastic:main Mar 29, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 292.5KB 292.5KB +15.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@cnasikas cnasikas cnasikas approved these changes

Assignees

@academo academo

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Delete button hover should be "Red" under Cases tab like in other tabs under application.
5 participants
@academo @elasticmachine @kibana-ci @peteharverson @cnasikas