[Security solution] [Endpoint] Revisit blocklist wrong labels #128773
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,6 +7,9 @@ | |||||
|
|
||||||
| import React, { memo } from 'react'; | ||||||
| import { i18n } from '@kbn/i18n'; | ||||||
| import { FormattedMessage } from '@kbn/i18n-react'; | ||||||
| import { DocLinks } from '@kbn/doc-links'; | ||||||
| import { EuiLink } from '@elastic/eui'; | ||||||
|
|
||||||
| import { useHttp } from '../../../../common/lib/kibana'; | ||||||
| import { ArtifactListPage, ArtifactListPageProps } from '../../../components/artifact_list_page'; | ||||||
|
|
@@ -48,52 +51,47 @@ const BLOCKLIST_PAGE_LABELS: ArtifactListPageProps['labels'] = { | |||||
| ), | ||||||
| flyoutCreateSubmitSuccess: ({ name }) => | ||||||
| i18n.translate('xpack.securitySolution.blocklist.flyoutCreateSubmitSuccess', { | ||||||
| defaultMessage: '"{name}" has been added to your blocklist.', | ||||||
| values: { name }, | ||||||
| }), | ||||||
| flyoutEditSubmitSuccess: ({ name }) => | ||||||
| i18n.translate('xpack.securitySolution.blocklist.flyoutEditSubmitSuccess', { | ||||||
| defaultMessage: '"{name}" has been updated.', | ||||||
| values: { name }, | ||||||
| }), | ||||||
| flyoutDowngradedLicenseDocsInfo: ( | ||||||
| securitySolutionDocsLinks: DocLinks['securitySolution'] | ||||||
| ): React.ReactNode => { | ||||||
| return ( | ||||||
| <> | ||||||
| <FormattedMessage | ||||||
| id="xpack.securitySolution.blocklist.flyoutDowngradedLicenseDocsInfo" | ||||||
| defaultMessage="For more information, see our " | ||||||
| /> | ||||||
| <EuiLink target="_blank" href={`${securitySolutionDocsLinks.blocklist}`}> | ||||||
| <FormattedMessage | ||||||
| id="xpack.securitySolution.blocklist.flyoutDowngradedLicenseDocsLink" | ||||||
| defaultMessage="Blocklist documentation" | ||||||
| /> | ||||||
| </EuiLink> | ||||||
| </> | ||||||
| ); | ||||||
| }, | ||||||
| deleteActionSuccess: (itemName) => | ||||||
| i18n.translate('xpack.securitySolution.blocklist.deleteSuccess', { | ||||||
| defaultMessage: '"{itemName}" has been removed from blocklist.', | ||||||
| values: { itemName }, | ||||||
| }), | ||||||
| emptyStateTitle: i18n.translate('xpack.securitySolution.blocklist.emptyStateTitle', { | ||||||
| defaultMessage: 'Add your first blocklist entry', | ||||||
| }), | ||||||
| emptyStateInfo: i18n.translate('xpack.securitySolution.blocklist.emptyStateInfo', { | ||||||
| defaultMessage: | ||||||
| 'The blocklist prevents selected applications from running on your hosts by extending the list of processes the Endpoint considers malicious.', | ||||||
|
There was a problem hiding this comment. Possible tweaks for flow and consistency, from feature sync discussion with @kevinlog, @caitlinbetz, @jmikell821:
Suggested change
|
||||||
| }), | ||||||
| emptyStatePrimaryButtonLabel: i18n.translate( | ||||||
| 'xpack.securitySolution.blocklist.emptyStatePrimaryButtonLabel', | ||||||
| { defaultMessage: 'Add blocklist entry' } | ||||||
| ), | ||||||
| searchPlaceholderInfo: i18n.translate('xpack.securitySolution.blocklist.searchPlaceholderInfo', { | ||||||
| defaultMessage: 'Search on the fields below: name, description, value', | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the screenshot above, there's a period missing at the end of this sentence, and "blocklist documentation" should probably be lowercase since the feature isn't a proper name.
"For more information, see our blocklist documentation."