[RAM] Disable rule status dropdown on readonly user #128971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
# Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
JiaweiWu
approved these changes
Mar 31, 2022
| @@ -60,6 +61,7 @@ export const RuleStatusDropdown: React.FunctionComponent<ComponentOpts> = ({ | |||
| enableRule, | |||
| snoozeRule, | |||
| unsnoozeRule, | |||
| isEditable, | |||
There was a problem hiding this comment.
should this default to true?
There was a problem hiding this comment.
I prefer making it a required prop. We shouldn't be using this component in any context where we can't determine if the rule is editable or not.
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Apr 2, 2022
* [RAM] Disable rule status dropdown on readonly user * Add test for readonly dropdown (cherry picked from commit 70fa265) # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx
1 task
Zacqary
added a commit
that referenced
this pull request
Apr 3, 2022
…129270) * [RAM] Disable rule status dropdown on readonly user (#128971) * [RAM] Disable rule status dropdown on readonly user * Add test for readonly dropdown (cherry picked from commit 70fa265) # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx * Remove previousSnoozeInterval * remove previousSnoozeInterval * remove previousSnoozeInterval * remove previousSnoozeInterval Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #128672
When logged in as a read-only user, the Enable/Disable/Snooze control will just be a normal badge, and won't open a dropdown.
Checklist