Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.2] Upgrade EUI to v53.0.1 (#128825) #129150

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[8.2] Upgrade EUI to v53.0.1 (#128825) #129150

merged 1 commit into from
Apr 1, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.2:

Questions ?

Please refer to the Backport tool documentation

Upgrade EUI to v53.0.1 (#128825)
46aa514 
* Upgrade EUI to v53.0.1

* Update i18n EUI mappings with new super date picker tokens

* Update deprecated prettyDuration usage

* Fix misc tests/type updates caused by EuiSuperDatePicker i18n release

- Fix mock typeof: this changed because the exported EuiSuperDatePicker is no longer a class, but a functional component wrapper around a class

- CI test: update now-capitalized datepicker select copy

- Jest tests: update snapshots, find()s (`Memo()` selector change is due to the exported EuiSuperDatePicker change)

* [kibana-app-services feedback] use renderToString

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6a44f1f)
@kibanamachine kibanamachine requested review from a team as code owners March 31, 2022 23:50
@kibanamachine kibanamachine enabled auto-merge (squash) March 31, 2022 23:50
@kibanamachine kibanamachine mentioned this pull request Mar 31, 2022
Merged
YulNaumenko
YulNaumenko approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Solution changes LGTM

afharo
afharo approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +1.0B
data 116.7KB 116.8KB +88.0B
enterpriseSearch 1.4MB 1.4MB +1.0B
fileUpload 821.1KB 821.1KB +1.0B
maps 2.5MB 2.5MB +1.0B
ml 3.3MB 3.3MB +1.0B
total +93.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 297.9KB 309.1KB +11.2KB
kbnUiSharedDeps-npmDll 4.8MB 4.8MB +7.0KB
uiActionsEnhanced 22.1KB 22.2KB +104.0B
total +18.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @constancecchen

@kibanamachine kibanamachine merged commit 5bdb075 into 8.2 Apr 1, 2022
@kibanamachine kibanamachine deleted the backport/8.2/pr-128825 branch April 1, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@cee-chen cee-chen

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kibanamachine @kibana-ci @afharo @YulNaumenko @cee-chen