[Security Solution] Deprecate outdated detection rules Bulk APIs #129448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcrzx
added
release_note:deprecation
Team:Detections and Resp
xcrzx
force-pushed
the
bulk-apis-deprecate
branch
4 times, most recently
from
b552997 to
24a7839
Compare
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
banderror
reviewed
Apr 6, 2022
...s/security_solution/server/lib/detection_engine/routes/rules/create_rules_bulk_route.test.ts
Show resolved
Hide resolved
...s/security_solution/server/lib/detection_engine/routes/rules/create_rules_bulk_route.test.ts
Show resolved
Hide resolved
x-pack/test/detection_engine_api_integration/basic/tests/create_rules_bulk.ts
Show resolved
Hide resolved
x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules_bulk.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/utils/deprecation.ts
Outdated
Show resolved
Hide resolved
xcrzx
force-pushed
the
bulk-apis-deprecate
branch
from
24a7839 to
5cb5c6d
Compare
xcrzx
force-pushed
the
bulk-apis-deprecate
branch
from
5cb5c6d to
f356856
Compare
💚 Build SucceededTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @xcrzx |
banderror
approved these changes
Apr 12, 2022
x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/utils/deprecation.ts
Show resolved
Hide resolved
x-pack/test/detection_engine_api_integration/security_and_spaces/tests/delete_rules_bulk.ts
Show resolved
Hide resolved
vitaliidm
reviewed
Apr 12, 2022
| * @returns string | ||
| */ | ||
| export const buildDeprecatedBulkEndpointMessage = (path: string) => { | ||
| const docsLink = getDocLinks({ kibanaBranch: 'main' }).siem.ruleApiOverview; |
There was a problem hiding this comment.
wonder, is it might be better to give a link to a latest stable release, rather main branch?
kibanamachine
pushed a commit
that referenced
this pull request
Apr 12, 2022
(cherry picked from commit a897747)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #127756
Summary
The following endpoints are not used from Kibana anymore and have been deprecated:
detection_engine/rules/_bulk_createdetection_engine/rules/_bulk_deletedetection_engine/rules/_bulk_updateTo let our users know about these deprecations we: