-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Rename uptime plugin to synthetics #130037
Changes from all commits
159213d
90551ff
0da7ad9
22bf27d
df4fe06
bc396d6
ee28498
8b2e81d
52fe501
c82c6ae
36d6a39
f290d24
a268532
cf95712
48ca61d
827f9e5
13002a5
7c78efa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"configPath": ["xpack", "uptime"], | ||
"id": "uptime", | ||
"id": "synthetics", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought we agreed not to change the id as of yet. I'm not against it, but wondering why you decided to go ahead and change it now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. feature id is what matters most, so i decided to go ahead with it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wondering how that will impact alerting RBAC, here: https://github.com/elastic/kibana/blob/main/packages/kbn-rule-data-utils/src/alerts_as_data_rbac.ts#L24 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @elastic/actionable-observability can you remind me if the values above are meant to be the plugin id? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Most likely feature id, since there are two from infra plugin logs and infrastructure |
||
"kibanaVersion": "kibana", | ||
"optionalPlugins": ["cloud", "data", "fleet", "home", "ml", "telemetry"], | ||
"requiredPlugins": [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these two values displayed? Are they displayed to the end user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think so.
Though the title goes here
