-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Docking for wide viewports #130811
Conversation
@elasticmachine merge upstream |
eb805eb
to
1342c4d
Compare
827fb7f
to
60c35bc
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically LGTM
@@ -24,3 +24,9 @@ | |||
text-decoration: underline; /* 2 */ | |||
} | |||
} | |||
|
|||
@media (max-width: 1439px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but EUI may have constants and/or mixins around the most common break points? an hardcoded value probably should be avoided.
if (lockRef.current) { | ||
lockRef.current.focus(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: lockRef.current?.focus()
I'm going to need some help sorting out the space accommodations for views with a bottom bar before this can get merged. I see there is something in the |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Finally. As per the feedback in [Discuss] Remove 'Dock navigation' feature #77072 this should have never been removed in the first place. What version will this be back in? |
Relates to #77072
Summary
Prior versions of Kibana provided the capability to dock the primary navigation. This capability was removed when we introduced the solution-level side navigation as to avoid side-by-side navigation and, in turn, potentially cluttering up the UI.
Fast forward in time and we continue to see a steady stream of requests to add the dock option back, especially for cases where people use larger displays. Also, the width of the left nav design is now less than where it started. Digging into our telemetry data, we have also learned that the most common viewport size is 1920 x 1080. With this in mind, this PR proposes adding back the docking capability but only for wider viewport sizes where there are less concerns of available UI real estate.
Specifically, this PR allows the docking option for viewport widths of 1440px and up.
Screenshots
Discover < 1440
Discover >= 1440
Observability < 1440 (w/ solution side nav)
Observability >= 1440 (w/ solution side nav)
Checklist
Delete any items that are not applicable to this PR.