Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Remove buffer usage #131319

Merged
merged 2 commits into from
May 3, 2022
Merged

[Synthetics] Remove buffer usage #131319

merged 2 commits into from
May 3, 2022

Conversation

shahzad31
Copy link
Contributor

Summary

As per #107280, removing usage of Buffer from synthetics client side

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 764.1KB 756.1KB -8.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 marked this pull request as ready for review May 2, 2022 15:37
@shahzad31 shahzad31 requested a review from a team as a code owner May 2, 2022 15:37
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 2, 2022
dominiqueclarke
dominiqueclarke approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but btoa triggers warnings.

@shahzad31 shahzad31 merged commit cbd13ec into elastic:main May 3, 2022
@shahzad31 shahzad31 deleted the remove-buffer-usage branch May 3, 2022 07:52
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 3, 2022
academo pushed a commit to academo/kibana that referenced this pull request May 4, 2022
@shahzad31
[Synthetics] Remove buffer usage (elastic#131319)
d74786e
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@shahzad31 @kertal
[Synthetics] Remove buffer usage (elastic#131319)
9216087
@shahzad31
Copy link
Contributor Author

Skip POST FF Testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @kibana-ci @dominiqueclarke @kibanamachine