Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] IIndexPattern / IndexPattern => DataView #133086

Merged
merged 9 commits into from
Jun 1, 2022
Merged

[data views] IIndexPattern / IndexPattern => DataView #133086

merged 9 commits into from
Jun 1, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented May 29, 2022 •
edited
Loading

Summary

Removal of deprecated IIndexPattern and IndexPattern types in favor of DataView.

@mattkime mattkime changed the title no more index pattern objects, only data view [data views] IIndexPattern / IndexPattern => DataView May 29, 2022
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.4.0 Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes labels May 29, 2022
@mattkime mattkime marked this pull request as ready for review May 30, 2022 14:27
@mattkime mattkime requested review from a team as code owners May 30, 2022 14:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team labels May 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

flash1293
flash1293 requested changes May 30, 2022
View reviewed changes
src/plugins/vis_default_editor/public/components/utils/editor_config.ts
@@ -7,7 +7,7 @@
*/

import { i18n } from '@kbn/i18n';
import { IndexPattern } from '@kbn/data-plugin/public';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vis_default_editor is not configured to rely on the data_views plugin

juliaElastic
juliaElastic approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet change LGTM

shahzad31
shahzad31 approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

flash1293
flash1293 approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VisEditors changes LGTM

kertal
kertal approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the cleanup 🙏 LGTM for Data Discovery team

sorenlouv
sorenlouv approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm changes lgtm

nreese
nreese approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM
code review

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2851 2834 -17
dataViews 698 689 -9
total -26

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 130.2KB 130.2KB -31.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 422.9KB 422.7KB -198.0B
dataViewEditor 10.5KB 10.4KB -145.0B
dataViews 40.0KB 39.8KB -186.0B
total -529.0B
Unknown metric groups

API count

id before after diff
data 3469 3448 -21
dataViews 849 838 -11
total -32

ESLint disabled in files

id before after diff
dataViews 4 3 -1

References to deprecated APIs

id before after diff
data 280 95 -185
dataViews 92 66 -26
discover 70 60 -10
maps 185 175 -10
savedObjects 27 2 -25
unifiedSearch 49 28 -21
ux 25 5 -20
visDefaultEditor 79 24 -55
total -352

Total ESLint disabled count

id before after diff
dataViews 8 7 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 3de1235 into elastic:main Jun 1, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 1, 2022
@alexwizp alexwizp mentioned this pull request Jun 8, 2022
Closed
@nlatipov nlatipov mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@vadimkibana vadimkibana vadimkibana approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@miltonhultgren miltonhultgren miltonhultgren approved these changes

@flash1293 flash1293 flash1293 approved these changes

@kertal kertal kertal approved these changes

@nreese nreese nreese approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.