[eslint-config-kibana] Upgrade eslint-config to 0.10.0.

[cjcenizal]

@simianhacker Would you mind going through the TSVB UI and making sure I haven't broken anything? I had to change a bunch of components to named exports, and I'm not sure I updated all of the import call sites to match.

[cjcenizal]

I renamed this component because I think the original name was a typo.

[spalger]

Changing these components from classes to function makes a lot more changed lines than necessary. Is this a requirement of the new eslint rules? Is it autofixable? If there are auto-fixed changes and manual changes, it would be great if they were in separate commits so they could be reviewed with different scrutiny.

[spalger]

If the class -> function conversion isn't necessary, I'd be fine with it still but another separate commit would be very helpful.

[cjcenizal]

Preferring stateless functional components is one of the rules I added, but no it isn't autofixable unfortunately. It also means moving a lot of default exports to named exports (which is also part of our style guide, I believe). I broke this PR up into 2 commits (automatic fixes and manual ones), for your convenience.

[spalger]

Awesome, thanks!

[spalger]

LGTM

[simianhacker]

PR's like this are practically un-review-able and quite frankly pretty risky based on the size alone. I would rather see you create 11 PR's for each new rule and the corresponding refactor then one massive PR like this. Another approach would be to try and isolate the reactor to logical components so they are not all jumbled up into one gigantic PR.

[cjcenizal]

@simianhacker I completely understand + agree. I think I can provide some guidance on this PR which will help you review it in its current form.

The following rules had no violations:

• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-direct-mutation-state.md
• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-will-update-set-state.md
• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-did-update-set-state.md
• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unknown-property.md
• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-es6-class.md
• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-is-mounted.md

The first commit contains autofixes -- do you want to review these? I'm not sure these can be affected by code review, unless you want to challenge a rule we've adopted. If you look at the commit with ?w=1 appended to ignore whitespace changes, there's very little to review: 595d37f?w=1. Here are the rules which have been applied:

• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-spacing.md
• http://eslint.org/docs/rules/jsx-quotes

The second commit consists of manual fixes, but if you look at the commit with whitespace ignored, it's also a lot easier to follow: e422a3b?w=1. Here are the rules I applied:

• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-multi-comp.md (I ignored the single violation of this rule)
• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-did-mount-set-state.md (I ignored the single violation of this rule)
• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-stateless-function.md
• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unescaped-entities.md

The prefer-stateless-function rule incurred the most changes, but they involved a straightforward pattern:

• Convert the component into a stateless function, which involved a large whitespace change
• Convert the default export to a named export (which is the part I'm most concerned about, and need your help with)

Does this help?

[simianhacker]

I reviewed this to the best of my abilities... reviewed the code and tested (manually) all the aggs that where refactored) LGETM

[cjcenizal]

Thanks @simianhacker !