-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Use docker to manage dependencies #13347
Conversation
Before: |
I'm going to revert the change that runs this on CI so we can unblock this. For now it can be considered ease of use utility. |
ccc128d
to
7055ee5
Compare
I would like to get this running on CI to avoid having multiple paths this could go through. I also think that getting Docker in CI will allow us to utilize it more in the future. |
jenkins, test it |
cf1ae79
to
2327063
Compare
CONTRIBUTING.md
Outdated
@@ -306,12 +306,9 @@ npm run test:browser -- --dev # remove the --dev flag to run them once and close | |||
|
|||
### Building OS packages | |||
|
|||
Packages are built using fpm, pleaserun, dpkg, and rpm. fpm and pleaserun can be installed using gem. Package building has only been tested on Linux and is not supported on any other platform. | |||
Packages are built in a Docker container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should note Docker being a dependency for creating builds.
92cd7f2
to
5a1c7d5
Compare
jenkins, test it |
This should be good to go now. Finally. |
@@ -0,0 +1,35 @@ | |||
ARG node_version | |||
FROM node:$node_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are alpine images available for this, just append -alpine
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't yet. the node image is based on 3.4 and rpm isn't available https://pkgs.alpinelinux.org/packages?name=rpm&branch=&repo=&arch=&maintainer=
I have been playing around with this off-and-on, and I am not sure about doubling the build times. Thoughts on having a task to build and publish the container to our docker repository? I am curious how much time that will shave off or how close it would get to the current build time. |
We could, but we'd have to remove
so we don't end up with wrong versions. I'll do some timing on this and see if there's other options too. |
Closing until I revisit, I haven't been working on this. |
The goal of this is to move dependency management under direct control of kibana, instead of relying on the host machine.
This attempts to fix several issues:
With docker and docker-compose installed, building should work the same as it did previously.