Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics]Sort monitor list by frequency column #133713

Merged
merged 5 commits into from
Jun 16, 2022
Merged

[Synthetics]Sort monitor list by frequency column #133713

merged 5 commits into from
Jun 16, 2022

Conversation

shahzad31
Copy link
Contributor

Summary

Sort monitor list by frequency column !!

@shahzad31 shahzad31 marked this pull request as ready for review June 7, 2022 15:58
@shahzad31 shahzad31 requested a review from a team as a code owner June 7, 2022 15:58
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 7, 2022
@shahzad31 shahzad31 requested a review from awahab07 June 7, 2022 15:59
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 867.0KB 867.0KB +25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

awahab07
awahab07 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sort by Frequency works now without errors.

@shahzad31 shahzad31 merged commit b041f04 into elastic:main Jun 16, 2022
@shahzad31 shahzad31 deleted the sort-by-frequency branch June 16, 2022 10:02
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 16, 2022
@awahab07 awahab07 mentioned this pull request Jun 16, 2022
Closed
4 tasks
@awahab07 awahab07 mentioned this pull request Nov 7, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @elasticmachine @kibana-ci @awahab07 @kibanamachine