Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logging][Docs] Add upper limit to rolling file appender numeric strategy #134170

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

TinaHeiligers
Copy link
Contributor

There's a hard-coded upper limit to the rolling file appender numeric strategy that, when exceeded, will throw config errors on Kibana startup but is not documented.
This PR adds the max to the 7.17 docs.

Note: Kibana's docs were rearranged in v8 and this PR makes the doc change only to the 7.17 branch. we will still need to add the change to subsequent versions.

  • Documentation was added for features that require explanation or tutorials

…tegy.

There's a hard-coded upper limit to the rolling file appender numeric strategy that, when exceeded, will throw config errors on Kibana startup but is not documented.
This PR adds the max to the docs.
@TinaHeiligers TinaHeiligers added release_note:skip Skip the PR/issue when compiling release notes v7.17.0 v7.17.1 v7.17.2 v7.17.3 v7.17.4 v7.17.5 Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Logging docs auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

TinaHeiligers added a commit that referenced this pull request Jun 11, 2022
There's a hard-coded upper limit to the rolling file appender numeric strategy that, when exceeded, will throw config errors on Kibana startup but is not documented.
This PR adds the max to the `8.x` docs.

Note: Kibana's docs were rearranged in v8. The update to the `7.17` docs is handled in #134170
TinaHeiligers added a commit that referenced this pull request Jun 11, 2022
There's a hard-coded upper limit to the rolling file appender numeric strategy that, when exceeded, will throw config errors on Kibana startup but is not documented.
This PR adds the max to the `8.x` docs.

Note: Kibana's docs were rearranged in v8. The update to the `7.17` docs is handled in #134170
@TinaHeiligers TinaHeiligers requested review from a team June 11, 2022 23:28
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@TinaHeiligers TinaHeiligers enabled auto-merge (squash) June 13, 2022 16:46
@TinaHeiligers TinaHeiligers merged commit 8870374 into 7.17 Jun 13, 2022
@TinaHeiligers TinaHeiligers deleted the TinaHeiligers-patch-1 branch June 13, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs Feature:Logging release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.0 v7.17.1 v7.17.2 v7.17.3 v7.17.4 v7.17.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants