Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Install a default ingest pipeline for datastreams without ones #134342

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jun 14, 2022

Description

Related to #133740

Install a default ingest pipeline for all the datastreams managed by Fleet event if there is none,
The ingest pipeline will be named like this ${dataStream.type}-${dataStream.dataset}-${packageVersion} (Following the same convention as datastream ingest pipeline added by the package)

How to test that PR?

You can install a package and see that the datastreams without pipeline get one created without any processors

Screen Shot 2022-06-15 at 10 07 29 AM

Screen Shot 2022-06-15 at 10 07 48 AM

I also tested to install all packages node scripts/install_all_packages and no errors did come out

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jun 14, 2022
@nchaulet nchaulet self-assigned this Jun 14, 2022
@nchaulet nchaulet force-pushed the feature-default-pipeline-fleet-all-datastreams branch 3 times, most recently from ddcc292 to 25145f1 Compare June 14, 2022 17:27
@nchaulet nchaulet force-pushed the feature-default-pipeline-fleet-all-datastreams branch from a2ad2ec to 26bc7ac Compare June 14, 2022 17:35
@nchaulet nchaulet force-pushed the feature-default-pipeline-fleet-all-datastreams branch from 964315f to 4b9e568 Compare June 14, 2022 18:38
@nchaulet nchaulet marked this pull request as ready for review June 15, 2022 14:09
@nchaulet nchaulet requested a review from a team as a code owner June 15, 2022 14:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
fleet 51 52 +1

Total ESLint disabled count

id before after diff
fleet 59 60 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet requested a review from kpollich June 15, 2022 19:00
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! Thanks for moving some of these functions into helpers.ts and adding unit tests 🚀

@nchaulet nchaulet merged commit 4da4b86 into elastic:main Jun 16, 2022
@nchaulet nchaulet deleted the feature-default-pipeline-fleet-all-datastreams branch June 16, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants