-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Install a default ingest pipeline for datastreams without ones #134342
Merged
nchaulet
merged 7 commits into
elastic:main
from
nchaulet:feature-default-pipeline-fleet-all-datastreams
Jun 16, 2022
Merged
[Fleet] Install a default ingest pipeline for datastreams without ones #134342
nchaulet
merged 7 commits into
elastic:main
from
nchaulet:feature-default-pipeline-fleet-all-datastreams
Jun 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddcc292
to
25145f1
Compare
a2ad2ec
to
26bc7ac
Compare
964315f
to
4b9e568
Compare
…-ref HEAD~1..HEAD --fix'
…ub.com:nchaulet/kibana into feature-default-pipeline-fleet-all-datastreams
Pinging @elastic/fleet (Team:Fleet) |
💚 Build SucceededMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kpollich
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me! Thanks for moving some of these functions into helpers.ts
and adding unit tests 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #133740
Install a default ingest pipeline for all the datastreams managed by Fleet event if there is none,
The ingest pipeline will be named like this
${dataStream.type}-${dataStream.dataset}-${packageVersion}
(Following the same convention as datastream ingest pipeline added by the package)How to test that PR?
You can install a package and see that the datastreams without pipeline get one created without any processors
I also tested to install all packages
node scripts/install_all_packages
and no errors did come out