Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] remove requirement that CI runs for readme changes #134504

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 15, 2022

In #74388 I added a requirement that CI runs for plugin readme changes. With the changes to the docs in the last year it seems this requirement can be lifted and PRs shouldn't need to run full CI just because some plugin readmes have been updated.

@spalger spalger added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Jun 15, 2022
@spalger spalger requested a review from a team as a code owner June 15, 2022 17:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger enabled auto-merge (squash) June 15, 2022 17:48
@spalger spalger added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:all-open Backport to all branches that could still receive a release labels Jun 15, 2022
@spalger spalger merged commit 284a564 into elastic:main Jun 15, 2022
@spalger spalger deleted the remove/required-ci-for-readmes branch June 15, 2022 18:02
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.3 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 134504

Questions ?

Please refer to the Backport tool documentation

spalger pushed a commit to spalger/kibana that referenced this pull request Jun 15, 2022
(cherry picked from commit 284a564)

# Conflicts:
#	.buildkite/pull_requests.json
spalger pushed a commit that referenced this pull request Jun 15, 2022
…34511)

(cherry picked from commit 284a564)

# Conflicts:
#	.buildkite/pull_requests.json
spalger pushed a commit that referenced this pull request Sep 1, 2022
spalger pushed a commit that referenced this pull request Sep 1, 2022
spalger pushed a commit that referenced this pull request Sep 1, 2022
@spalger
Copy link
Contributor Author

spalger commented Sep 1, 2022

Reverted in main, 8.4, and 8.3, because node scripts/build_plugin_list_docs still uses the readmes in every plugin to create the plugin list and when they're updated the plugin list needs to be updated.

Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes reverted Team:Operations Team label for Operations Team v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants