ES Client: use ClusterConnectionPool instead of WeightedConnectionPool
#134628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
bug
pgayvallet
commented
Jun 17, 2022
Comment on lines
+38
to
+39
| // using ClusterConnectionPool until https://github.com/elastic/elasticsearch-js/issues/1714 is addressed | ||
| ConnectionPool: ClusterConnectionPool, |
There was a problem hiding this comment.
I didn't add an integration test here because:
- Ihmo we shouldn't be testing the
@elastic/elasticsearchbehavior from Kibana tests - The test would be quite long (starting multiple ES nodes at least twice), and by nature, likely flaky
If we really want, I can add one though
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jun 17, 2022
(cherry picked from commit 6decdc3) # Conflicts: # src/core/server/elasticsearch/client/configure_client.ts
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jun 17, 2022
(cherry picked from commit 6decdc3) # Conflicts: # src/core/server/elasticsearch/client/configure_client.ts
pgayvallet
added a commit
that referenced
this pull request
Jun 17, 2022
(cherry picked from commit 6decdc3) # Conflicts: # src/core/server/elasticsearch/client/configure_client.ts
pgayvallet
added a commit
that referenced
this pull request
Jun 17, 2022
(cherry picked from commit 6decdc3) # Conflicts: # src/core/server/elasticsearch/client/configure_client.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We discovered a bug in
@elastic/elasticsearch-jsthat causes Kibana to not be able to connect to ES nodes for a predetermined amount of requests when using a multi-node configuration and when some, or all, nodes go down then up again: elastic/elasticsearch-js#1714Until the upstream issue is addressed, we will fall back to using the
ClusterConnectionPoolimplementation instead ofWeightedConnectionPool, as this implementation (which was the one used by the version7.xof the client) doesn't have this issue.Checklist
Release Note
Fix a bug causing ES nodes going down then up again to be unreachable by Kibana for a given amount of requests, when Kibana is configured to connect to multiple ES node