[Ingest Pipeline] Provide url params to use ingestPipeline UI from Fleet

[nchaulet]

Summary

Related to #133740

In the Fleet UI we will link to the ingest pipeline UI to show, edit or create a new pipeline and we want users to be redirected to Fleet after interacting with ingest pipeline app.

That PR allow to do so by introducing a redirect_path query parameter for all the CRUD ingest pipeline pages and a name parameter for the create pipeline page (when the name parameter is provided name is not editable).

Work in progress

How to manually test that PR

Until the workflow is completely implemented in Fleet you can test it like this

1. Navigate to /app/management/ingest/ingest_pipelines/create?name=logs-system.syslog@custom&redirect_path=/app/fleet the name should be prefilled and not editable

On save you should be redirected to fleet

2. then you can test the following urls and you should be redirect in fleet on save or close
   /app/management/ingest/ingest_pipelines/?pipeline=logs-system.syslog@custom&redirect_path=/app/fleet
/app/management/ingest/ingest_pipelines/edit/logs-system.syslog@custom?redirect_path=/app/fleet

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[elasticmachine]

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

[alisonelizabeth]

Hi @nchaulet! Thanks for taking this on.

I left a couple comments in the code around naming. Let me know what you think.

I also have a few questions after testing:

• How will the custom pipeline names be generated from Fleet? Will we ever run into a situation where the user is taken to the create pipeline page, and the pipeline already exists? Seems like that could be a poor UX since the name is not editable, but I don't have a clear understanding of the full flow.

• Once this is implemented on the Fleet side, will the redirect_path include the base path, i.e., /czy/app/fleet instead of /app/fleet? The current example in your PR description returns a 404.

• What is the expected behavior for the following comment? I currently see a 404 and the query param displays in the flyout.

then you can test the following urls and you should be redirect in fleet on save or close
/app/management/ingest/ingest_pipelines/?pipeline=logs-system.syslog@custom?redirect_path=/app/fleet

[alisonelizabeth]

At the moment, I can't think of many use cases where we would want to disallow editing the pipeline name on create (generally speaking, what's allowed via the ES API we don't block in the UI). That said, do you think it makes more sense to name this prop specific to fleet, something like isIntegrationPipeline?

Or, if we leave as-is, I think it might be helpful to add a code comment explaining its usage.

[nchaulet]

I am in favor of adding a comment here, to avoid to much fleet specifity here.

[alisonelizabeth]

One more thing - do you think you could add client integration tests for this flow as well? Let me know if you need any help with this. Thanks!

[nchaulet]

@alisonelizabeth thanks for the review

How will the custom pipeline names be generated from Fleet? Will we ever run into a situation where the user is taken to the create pipeline page, and the pipeline already exists? Seems like that could be a poor UX since the name is not editable, but I don't have a clear understanding of the full flow.

we have a convention to create the name in Fleet, and we will check if the custom pipeline exists before to show the user a create button or an edit one and send it to the correct ingest pipeline page.

Once this is implemented on the Fleet side, will the redirect_path include the base path, i.e., /czy/app/fleet instead of /app/fleet? The current example in your PR description returns a 404.

Yes the redirect_path in Fleet will include the bath path, my bad for the example I am testing without a basepath

What is the expected behavior for the following comment? I currently see a 404 and the query param displays in the flyout.

I made a mistake in the URL query parameter should be fixed

[alisonelizabeth]

Thanks for addressing my feedback! I did not retest, but code changes LGTM.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 8cc8658
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
ingestPipelines	457	459	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
ingestPipelines	451.7KB	452.3KB	+611.0B

History

• 💚 Build #52086 succeeded d004187
• 💚 Build #51957 succeeded 20c2a8f
• 💔 Build #51954 failed 70c32bcca2c3176496566522ca386850bbe403b9
• 💔 Build #51949 failed 50b6d43a0f782f63e7488be1c8f2edad6bac6d87

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet