Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y tests for dashboard controls #135085

Merged
merged 14 commits into from
Jun 27, 2022
Merged

a11y tests for dashboard controls #135085

merged 14 commits into from
Jun 27, 2022

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Jun 23, 2022 •
edited by ThomThomson
Loading

Meta - #51456

Closes #130488

Adding a11y tests for the new awesome dashboard controls.

@bhavyarm bhavyarm self-assigned this Jun 23, 2022
@bhavyarm bhavyarm added v8.4.0 Project:Accessibility Feature:Dashboard Dashboard related features Project:Controls Team:QA Team label for QA Team release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 labels Jun 23, 2022
@bhavyarm
Copy link
Contributor Author

Flaky test run - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/777

@bhavyarm bhavyarm marked this pull request as ready for review June 24, 2022 00:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jun 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@bhavyarm bhavyarm added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 24, 2022
@bhavyarm
Copy link
Contributor Author

Second flaky test run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/779

ThomThomson
ThomThomson approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, plus the two flaky test runners passing... LGTM!

One suggestion for an additional test, it might be good to take snapshots with the Control interaction popovers open, like the Options List selection popover, or the range slider selection popover.

Thank you so much for doing this, it was one of the last pieces we needed in Controls Phase II, so I've linked this PR to the issue we created to add a11y tests!

x-pack/test/accessibility/apps/dashboard_controls.ts Show resolved Hide resolved
@bhavyarm
Copy link
Contributor Author

@ThomThomson added in the extra test. Thanks for the review!

@bhavyarm bhavyarm mentioned this pull request Jun 27, 2022
Closed
Heenawter
Heenawter approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + ran tests locally - works great 👍

x-pack/test/accessibility/apps/dashboard_controls.ts Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #3 / Kibana Tags Page Accessibility tag assignment panel meets a11y requirements

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm
Copy link
Contributor Author

Thanks for the review @Heenawter <3

@bhavyarm bhavyarm merged commit 5c914d7 into elastic:main Jun 27, 2022
kibanamachine pushed a commit that referenced this pull request Jun 27, 2022
@bhavyarm
a11y tests for dashboard controls (#135085)
f633792 
(cherry picked from commit 5c914d7)
@kibanamachine kibanamachine mentioned this pull request Jun 27, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 28, 2022
@kibanamachine @bhavyarm
a11y tests for dashboard controls (#135085) (#135275)
189a635 
(cherry picked from commit 5c914d7)

Co-authored-by: Bhavya RM <bhavya@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@rashmivkulkarni rashmivkulkarni Awaiting requested review from rashmivkulkarni

Assignees

@bhavyarm bhavyarm

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Accessibility Project:Controls release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:QA Team label for QA Team v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Controls] Add accessibility tests
6 participants
@bhavyarm @elasticmachine @kibana-ci @kibanamachine @Heenawter @ThomThomson