-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Prompt user of unsaved changes in package policy edit page #135219
[Fleet] Prompt user of unsaved changes in package policy edit page #135219
Conversation
Pinging @elastic/fleet (Team:Fleet) |
@juliaElastic the scoped history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@juliaElastic Actually I was able to provide a custom modal by playing a little with the |
019d376
to
a388a3d
Compare
@elastic/kibana-core I had to change the |
@@ -320,7 +320,7 @@ export class ApplicationService { | |||
navigateToApp, | |||
navigateToUrl: async ( | |||
url: string, | |||
{ skipAppLeave = false, forceRedirect = false }: NavigateToUrlOptions = {} | |||
{ skipAppLeave = false, forceRedirect = false, state }: NavigateToUrlOptions = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the associated unit test here:
describe('navigateToUrl with options', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
Summary
Related to #133740
That PR add a prompt when the user try to leave the package policy editor pages with unsaved changes, this is particularly important as we added a new flow with custom pipelines where user are redirect from the editor page to the ingest pipeline UI.
UI Changes
How to test?
Try to edit an integration: