Improves dark theme support in the filter editor #13522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
added
Feature:Dashboard
cjcenizal
suggested changes
Aug 16, 2017
There was a problem hiding this comment.
In ui_framework/doc_site/src/views/modal/modal_example.js could you add this to line 36:
<GuideDemo isDarkTheme>
<StaticConfirmModal />
</GuideDemo>Then if you look at the example in the UI Framework, you can see the color of the text is off:
We can fix this by making the following changes to modal/_modal.scss:
.kuiModalHeader__title {
font-size: $globalTitleFontSize;
@include darkTheme {
color: $globalTextColor--darkTheme;
}
}
.kuiModalBodyText {
font-size: 14px;
@include darkTheme {
color: $globalTextColor--darkTheme;
}
}
| @localNavDepth: 3; /* 1 */ | ||
| @dashboardGridDepth: 1; /* 2 */ |
| @@ -4,5 +4,9 @@ $modalBackgroundColor: #FFF; | |||
| $modalOverlayBackground: rgba(#000000, 0.5); | |||
| $globalModalDepth: 1000; | |||
|
|
|||
| // Dark theme colors | |||
| $modalBorderColor--darkTheme: #000; | |||
| $modalBackgroundColor--darkTheme: #272727; | |||
There was a problem hiding this comment.
Could you change this to #525252? This will help the modal contrast against the background better.
|
This looks awesome overall btw |
|
Does this also fix #12988? |
|
Thanks for the review @cjcenizal, I've made those updates. @trevan unfortunately no, that modal lies outside of the application container, so the dark theme styles aren't getting applied to it. The changes in this PR might make it a little easier for someone to fix though. |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 18, 2017
Fixes elastic#12955 * Added dark theme support to the ui framework modal component * Also fixed z-index issue where dashboard panels would appear above the filter editor modal when the user moved or resized the panel (see gif below)
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 18, 2017
Fixes elastic#12955 * Added dark theme support to the ui framework modal component * Also fixed z-index issue where dashboard panels would appear above the filter editor modal when the user moved or resized the panel (see gif below)
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 18, 2017
Fixes elastic#12955 * Added dark theme support to the ui framework modal component * Also fixed z-index issue where dashboard panels would appear above the filter editor modal when the user moved or resized the panel (see gif below)
Bargs
added a commit
that referenced
this pull request
Aug 18, 2017
Fixes #12955 * Added dark theme support to the ui framework modal component * Also fixed z-index issue where dashboard panels would appear above the filter editor modal when the user moved or resized the panel (see gif below)
Bargs
added a commit
that referenced
this pull request
Aug 18, 2017
Fixes #12955 * Added dark theme support to the ui framework modal component * Also fixed z-index issue where dashboard panels would appear above the filter editor modal when the user moved or resized the panel (see gif below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12955
Note: I didn't change the colors of the uiSelect dropdowns. I took a swing at it but it turned into a big mess. There's tons of bootstrap and uiSelect styles that need to be overridden to do this properly. The white dropdowns don't look too bad to me, so I think if we want to add dark theme support to uiSelect we should do that in a separate PR.
z-index issue