Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet[ Allow to specify a datastream id in the edit integration page #135321

Merged
merged 5 commits into from
Jun 30, 2022
Merged

[Fleet[ Allow to specify a datastream id in the edit integration page #135321

merged 5 commits into from
Jun 30, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jun 28, 2022 •
edited
Loading

Summary

Related to #133740

Allow to specify a datastreamId in the package policy editor UI to navigate back to the datastream when viewing custom pipeline or mappings.

UI Changes

demo-nav.mov

@nchaulet nchaulet self-assigned this Jun 28, 2022
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 28, 2022
@nchaulet nchaulet marked this pull request as ready for review June 28, 2022 19:25
@nchaulet nchaulet requested a review from a team as a code owner June 28, 2022 19:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic reviewed Jun 30, 2022
View reviewed changes
...tions/fleet/sections/agent_policy/create_package_policy_page/components/datastream_hooks.tsx
packagePolicyId,
});

return `${baseUrl}${dataStreamId ? `?datastreamId=${encodeURIComponent(dataStreamId)}` : ''}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to add some unit tests on the url building logic

juliaElastic
juliaElastic reviewed Jun 30, 2022
View reviewed changes
...policy/create_package_policy_page/components/steps/components/package_policy_input_panel.tsx Outdated
@@ -43,13 +44,13 @@ const ShortenedHorizontalRule = styled(EuiHorizontalRule)`
const shouldShowStreamsByDefault = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great to test this logic, maybe you could move this to a helper function so it can be tested without the component

juliaElastic
juliaElastic approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet enabled auto-merge (squash) June 30, 2022 13:38
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / lens app - group 3 "after all" hook: afterTestSuite.trigger in "lens app - group 3"
  • [job] [logs] FTR Configs #32 / lens app - group 3 lens drag and drop tests "after all" hook: afterTestSuite.trigger in "lens drag and drop tests"
  • [job] [logs] FTR Configs #32 / lens app - group 3 lens drag and drop tests dropping between layers "after all" hook: afterTestSuite.trigger for "can combine dimensions"
  • [job] [logs] FTR Configs #32 / lens app - group 3 lens drag and drop tests dropping between layers should move the column

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 732 733 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1368 1370 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 837.8KB 838.4KB +599.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 110.7KB 110.9KB +124.0B
Unknown metric groups

API count

id before after diff
fleet 1499 1501 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 0bc5822 into elastic:main Jun 30, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 30, 2022
@nchaulet nchaulet deleted the feature-edit-integration-allow-datastream-id branch June 30, 2022 14:59
yakhinvadim pushed a commit to yakhinvadim/kibana that referenced this pull request Jul 5, 2022
@nchaulet
[Fleet[ Allow to specify a datastream id in the edit integration page (…
10a5fb1 
…elastic#135321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibana-ci @juliaElastic @kibanamachine