You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is part of the issue to refactor the <TableListView /> component. (#135020). I decided to split the work in smaller PRs to make it easier to review.
In this initial PR the changes are: converting the previous Class component to a Function component. I've decided to have a reducer to manage the state as it is the best way to make multiple changes to the component state at once and we expect the state management of the component to grow in complexity with future work on the UX redesign.
How to test
Navigate to the dashboard list view and make sure that everything works as expected
List the dashboard
Query (search bar)
Delete one or multiple dashboard
Tagging column appear if there are tags
Edit a dashboard
Note: This PR is going to the feature branch. Tests will be added later (#135811). This PR is just converting the actual component without adding any new functionalities.
Note 2: There is an issue in EUI with the sorting controlled by the consumer. I've opened an issue (elastic/eui#6032). Until it is fixed, the "updatedAt" column can't toggle between "asc" and "desc".
[job][logs] FTR Configs #31 / ObservabilityApp Observability Rule Details page Page components maps correctly the rule type with the human readable rule type
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.
The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the issue to refactor the
<TableListView />
component. (#135020). I decided to split the work in smaller PRs to make it easier to review.In this initial PR the changes are: converting the previous Class component to a Function component. I've decided to have a reducer to manage the state as it is the best way to make multiple changes to the component state at once and we expect the state management of the component to grow in complexity with future work on the UX redesign.
How to test
Navigate to the dashboard list view and make sure that everything works as expected
Note: This PR is going to the feature branch. Tests will be added later (#135811). This PR is just converting the actual component without adding any new functionalities.
Note 2: There is an issue in EUI with the sorting controlled by the consumer. I've opened an issue (elastic/eui#6032). Until it is fixed, the "updatedAt" column can't toggle between "asc" and "desc".