Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - support tiny trained models #136010

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jul 8, 2022

Summary

This PR adds support for importing tiny trained PyTorch models during functional tests.

Details

  • Add six tiny PyTorch models (config, vocabulary, definition) to x-pack/test/functional/services/ml/resources/trained_model_definitions:
    • pt_tiny_fill_mask
    • pt_tiny_ner
    • pt_tiny_pass_through
    • pt_tiny_text_classification
    • pt_tiny_text_embedding
    • pt_tiny_zero_shot
  • Add corresponding service methods to deal with the model files and to import them into the deployment
  • Add tests to the model_list suite: import all 6 supported tiny models and checks row contents for all of them
  • Some minor service method cleanup

Imported models during the test run look like this:
image

@pheyos pheyos added :ml test_ui_functional release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 8, 2022
@pheyos pheyos self-assigned this Jul 8, 2022
@pheyos pheyos requested a review from a team as a code owner July 8, 2022 13:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Jul 11, 2022

@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job adding this in! LGTM

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small comment but generally LGTM

@jgowdyelastic
Copy link
Member

Latest changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos pheyos merged commit e3ea3fd into elastic:main Jul 11, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 11, 2022
@pheyos pheyos deleted the import_trained_models_in_tests branch July 11, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants