Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rule Registry] Additional error logging #136225

Merged
merged 8 commits into from
Jul 22, 2022
Merged

[Rule Registry] Additional error logging #136225

merged 8 commits into from
Jul 22, 2022

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jul 12, 2022 •
edited
Loading

Resolves #106315

Summary

  • Added error logging for rule registry errors to better track where ES error might be occurring during rule execution.

@ymao1 ymao1 changed the title Rule registry/log es errors [Rule Registry] Additional error logging Jul 12, 2022
@ymao1 ymao1 self-assigned this Jul 12, 2022
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/Alerts-as-Data Issues related to Alerts-as-data and RuleRegistry v8.4.0 labels Jul 12, 2022
@ymao1
Copy link
Contributor Author

ymao1 commented Jul 12, 2022

@elasticmachine merge upstream

@ymao1 ymao1 marked this pull request as ready for review July 12, 2022 20:48
@ymao1 ymao1 requested review from a team as code owners July 12, 2022 20:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

mikecote
mikecote approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@ymao1
Copy link
Contributor Author

ymao1 commented Jul 18, 2022

@elasticmachine merge upstream

fkanout
fkanout approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some nit comments.

x-pack/plugins/rule_registry/server/rule_data_client/rule_data_client.ts Outdated Show resolved Hide resolved
x-pack/plugins/rule_registry/server/rule_data_client/rule_data_client.ts Outdated Show resolved Hide resolved
@ymao1
Copy link
Contributor Author

ymao1 commented Jul 22, 2022

@elasticmachine merge upstream

@ymao1 ymao1 enabled auto-merge (squash) July 22, 2022 12:42
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 disabled auto-merge July 22, 2022 14:09
@ymao1 ymao1 merged commit debc23b into elastic:main Jul 22, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 22, 2022
@ymao1 ymao1 deleted the rule-registry/log-es-errors branch July 22, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@fkanout fkanout fkanout approved these changes

Assignees

@ymao1 ymao1

Labels
backport:skip This commit does not require backporting Feature:Alerting/Alerts-as-Data Issues related to Alerts-as-data and RuleRegistry release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RAC] RAC framework calls to ES should wrap their own errors
6 participants
@ymao1 @elasticmachine @kibana-ci @mikecote @fkanout @kibanamachine