dataviews.clearCache cleanup

[ppisljar]

Summary

dataviews.clearCache(id?: string) was cleaned up, before it cleaned the data view saved objects cache as well as data view instance cache. The method was split into two methods:

• clearCache() which clears data view saved object cache
• clearInstanceCache(id?: string): which clears the data view instance cache

for apps that used to clear whole instance cache (discover) unified search data view selector was updated to refresh the field list on data view change and discover also refreshes the field list of a data view on load to make sure user always gets the recent field list.

Checklist

Delete any items that are not applicable to this PR.

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

[mattkime]

It seems this code had some undesirable functional overlap to begin with. the savedObjectsCache is really a list of data views whereas the dataViewCache actually stores DataView instances. They'd be cleared in slightly different situations, whether you're getting a fresh list or fresh DataView instance. What are the needs and intentions of the api consumer code? I think this gets lost when clearCache always clears the data view list cache and optionally clears the dataView cache. Determining api consumers intentions might be more work than the code changes in which case perhaps we should deprecate this method and replace it with two new methods.

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 01e579f
• Storybooks Preview

Failed CI Steps

• FTR Configs #15

Test Failures

• [job] [logs] FTR Configs #15 / Status page Status Page "before all" hook for "allows user to navigate without authentication"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
data	2402	2404	+2
dataViews	199	202	+3
total			+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dataViewManagement	143.6KB	143.6KB	+8.0B
discover	492.4KB	492.5KB	+35.0B
total			+43.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dataViews	40.7KB	40.7KB	+39.0B
unifiedSearch	44.0KB	44.1KB	+74.0B
total			+113.0B

Unknown metric groups

API count

id	before	after	diff
data	3075	3077	+2
dataViews	938	942	+4
total			+6

History

• 💔 Build #58081 failed cfe91bbe0d989dcc9e8b310103d0b6d57c6b8a4e
• 💔 Build #57741 failed 6d69a86d501f33d1dcdc7f34ffbe5912a7ca8191
• 💔 Build #57665 failed ff7920ec3966e0c5f11c20c8bee6200648c237db
• 💔 Build #57362 failed d1b8b3ecf67af1e0e1183de978a2e2dbbc75d70c
• 💔 Build #57283 failed f84d9ca294a72897d9b262f612a237c2f56c9481

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jughosta]

LGTM!

[mattkime]

changes lgtm, nice work