Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4] [Portable Dashboards] Prep Redux Tools (#136572) #137595

Closed

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.4:

Questions ?

Please refer to the Backport tool documentation

* Created new Redux system for embeddables in Presentation Util. Migrated all Controls to use it.

(cherry picked from commit 01fc584)
@ThomThomson
Copy link
Contributor

Closing this - backport created accidentally

auto-merge was automatically disabled July 29, 2022 14:45

Pull request was closed

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
controls 173 196 +23
presentationUtil 181 183 +2
total +25

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
controls 198 199 +1
presentationUtil 180 187 +7
total +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 428.3KB 443.4KB +15.1KB
dashboard 409.7KB 409.8KB +3.0B
presentationUtil 127.6KB 127.5KB -21.0B
total +15.0KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count 4939 4876 -63
total size 7.7MB 7.6MB -49.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
presentationUtil 11 12 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
controls 29.2KB 29.3KB +183.0B
presentationUtil 43.3KB 43.2KB -141.0B
total +42.0B
Unknown metric groups

API count

id before after diff
controls 206 207 +1
presentationUtil 231 243 +12
total +13

async chunk count

id before after diff
controls 6 7 +1

ESLint disabled line counts

id before after diff
presentationUtil 10 9 -1

Total ESLint disabled count

id before after diff
presentationUtil 12 11 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ThomThomson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants