-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed #138054
Conversation
…cannot be accessed or dismissed
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nreese what do you think of adding a min-width to the property labels?
.mapFeatureTooltip__propertyLabel {
min-width: $euiSizeXL * 2.5;
max-width: $euiSizeXL * 4;
font-weight: $euiFontWeightSemiBold;
}
The .eui-textBreakWord
that is passed to all table td
causes the words to break but for this particular scenario, when the word breaks it doesn't leave enough space for the .mapFeatureTooltip__propertyLabel
:
By ensuring there's always a min-width for .mapFeatureTooltip__propertyLabel
when the words break it takes into account the min-width: $euiSizeXL * 2.5
:
That looks much better. Thanks for the suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
code review and tested in chrome and firefox
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
…cannot be accessed or dismissed (elastic#138054) (elastic#138202) * [Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed * add min-width to mapFeatureTooltip__propertyLabel (cherry picked from commit 7cd4a86) Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Fixes #136428
To test