Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed #138054

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 3, 2022

Fixes #136428

Screen Shot 2022-08-03 at 3 04 35 PM

To test

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.5.0 labels Aug 3, 2022
@nreese nreese marked this pull request as ready for review August 4, 2022 02:11
@nreese nreese requested review from a team as code owners August 4, 2022 02:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from nickpeihl August 4, 2022 02:11
Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nreese what do you think of adding a min-width to the property labels?

.mapFeatureTooltip__propertyLabel {
  min-width: $euiSizeXL * 2.5;
  max-width: $euiSizeXL * 4;
  font-weight: $euiFontWeightSemiBold;
}

The .eui-textBreakWord that is passed to all table td causes the words to break but for this particular scenario, when the word breaks it doesn't leave enough space for the .mapFeatureTooltip__propertyLabel:

Screenshot 2022-08-04 at 18 28 52

By ensuring there's always a min-width for .mapFeatureTooltip__propertyLabel when the words break it takes into account the min-width: $euiSizeXL * 2.5:

Screenshot 2022-08-04 at 18 29 19

@nreese
Copy link
Contributor Author

nreese commented Aug 4, 2022

what do you think of adding a min-width to the property labels?

That looks much better. Thanks for the suggestion.

@nreese nreese requested a review from elizabetdev August 4, 2022 17:50
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested in chrome and firefox

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +188.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@nreese nreese merged commit 7cd4a86 into elastic:main Aug 5, 2022
kibanamachine pushed a commit that referenced this pull request Aug 5, 2022
…cannot be accessed or dismissed (#138054)

* [Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed

* add min-width to mapFeatureTooltip__propertyLabel

(cherry picked from commit 7cd4a86)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2022
…cannot be accessed or dismissed (elastic#138054) (elastic#138202)

* [Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed

* add min-width to mapFeatureTooltip__propertyLabel

(cherry picked from commit 7cd4a86)

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Maps release_note:fix v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed
7 participants