Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens embeddables/network #138374

Closed
wants to merge 67 commits into from
Closed

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Aug 9, 2022

Summary

This is part of #136409 #137882

To view the UI for the entire change #138791
https://kibana-pr-137882.kb.us-west2.gcp.elastic-cloud.com:9243
ask me or Monina for password

This PR is based on #138376, please do not merge with main , merge from #138376 only

Before
Screenshot 2022-08-11 at 13 10 48
Screenshot 2022-08-11 at 13 11 39
Screenshot 2022-08-11 at 13 11 26
Screenshot 2022-08-11 at 13 11 13

After
Screenshot 2022-08-11 at 14 36 14

Screenshot 2022-08-11 at 14 37 13

Screenshot 2022-08-11 at 14 37 00

Screenshot 2022-08-11 at 14 36 45

Screenshot 2022-08-11 at 14 36 31

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@angorayc angorayc mentioned this pull request Aug 9, 2022
9 tasks
angorayc and others added 28 commits August 17, 2022 13:12
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 26, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / authenticationLensAttributes should render
  • [job] [logs] Jest Tests #13 / AutoScale withAutoScale renders
  • [job] [logs] Jest Tests #7 / getEventsHistogramLensAttributes should render
  • [job] [logs] Jest Tests #7 / getExternalAlertLensAttributes should render
  • [job] [logs] Jest Tests #13 / interpreter/functions#metric returns an object with the correct structure
  • [job] [logs] Jest Tests #7 / kpiNetworkEventsLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiTlsHandshakesLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiTotalUsersAreaLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiTotalUsersMetricLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniqueFlowIdsLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniqueIpsAreaLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniqueIpsBarLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniqueIpsDestinationMetricLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniqueIpsSourceMetricLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniquePrivateIpsAreaLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniquePrivateIpsBarLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniquePrivateIpsDestinationMetricLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUniquePrivateIpsSourceMetricLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUserAuthenticationsAreaLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUserAuthenticationsBarLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUserAuthenticationsMetricFailureLensAttributes should render
  • [job] [logs] Jest Tests #7 / kpiUserAuthenticationsMetricSuccessLensAttributes should render
  • [job] [logs] Jest Tests #13 / MetricVisComponent should render correct structure for multi-value metrics
  • [job] [logs] Jest Tests #13 / MetricVisComponent should render correct structure for single metric
  • [job] [logs] FTR Configs #39 / runPipeline basic visualize loader pipeline expression tests full expression runs the expression and combines different checks
  • [job] [logs] FTR Configs #39 / runPipeline basic visualize loader pipeline expression tests full expression runs the expression and combines different checks
  • [job] [logs] FTR Configs #39 / runPipeline basic visualize loader pipeline expression tests full expression runs the expression and compares final output
  • [job] [logs] FTR Configs #39 / runPipeline basic visualize loader pipeline expression tests full expression runs the expression and compares final output
  • [job] [logs] FTR Configs #39 / runPipeline basic visualize loader pipeline expression tests full expression runs the expression and compares output at every step
  • [job] [logs] FTR Configs #39 / runPipeline basic visualize loader pipeline expression tests full expression runs the expression and compares output at every step
  • [job] [logs] FTR Configs #39 / runPipeline basic visualize loader pipeline expression tests reusing partial results does some screenshot comparisons
  • [job] [logs] FTR Configs #39 / runPipeline basic visualize loader pipeline expression tests reusing partial results does some screenshot comparisons
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with empty data
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with empty data
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with metric and bucket data
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with metric and bucket data
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with multiple metric data
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with multiple metric data
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with percentageMode option
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with percentageMode option
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with single metric data
  • [job] [logs] FTR Configs #39 / runPipeline legacyMetricVis pipeline expression tests correctly renders metric with single metric data

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionLegacyMetricVis 11.6KB 11.8KB +193.0B
lens 1.3MB 1.3MB +76.0B
securitySolution 9.5MB 9.5MB +211.0B
total +480.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionLegacyMetricVis 9.8KB 9.9KB +81.0B
expressions 98.0KB 98.1KB +29.0B
lens 29.2KB 29.3KB +58.0B
total +168.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 8 7 -1
total -2

ESLint disabled line counts

id before after diff
apm 81 79 -2
enterpriseSearch 21 19 -2
observability 45 44 -1
securitySolution 438 434 -4
synthetics 67 58 -9
threatIntelligence 11 8 -3
ux 10 9 -1
total -22

Total ESLint disabled count

id before after diff
apm 95 92 -3
enterpriseSearch 22 20 -2
observability 53 51 -2
securitySolution 515 511 -4
synthetics 73 64 -9
threatIntelligence 12 9 -3
ux 13 12 -1
total -24

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants