Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Unskip tests for bulk editing index patterns #138435

Merged
merged 1 commit into from
Aug 10, 2022
Merged

[Security Solution][Detections] Unskip tests for bulk editing index patterns #138435

merged 1 commit into from
Aug 10, 2022

Conversation

banderror
Copy link
Contributor

Ticket: #138409
Caused by: #138304 (comment)

Summary

The merge of #138304 caused unit tests for bulk editing index patterns to start failing. This PR was reverted by 0bc8cf7. The tests were skipped in 26a4783.

These tests are fully functional in main. Unskipping them.

@banderror banderror added bug Fixes for quality problems that affect the customer experience skipped-test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Aug 9, 2022
@banderror banderror requested a review from a team as a code owner August 9, 2022 17:42
@banderror banderror self-assigned this Aug 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror linked an issue Aug 9, 2022 that may be closed by this pull request
Failing test: Jest Tests.x-pack/plugins/security_solution/server/lib/detection_engine/rules/bulk_actions - ruleParamsModifier index_patterns should set dataViewId to undefined if overwriteDataViews=true on add_index_patterns action #138409
Closed
@banderror banderror enabled auto-merge (squash) August 9, 2022 17:54
@banderror banderror force-pushed the unskip-tests-for-bulk-editing-index-patterns branch from 2774435 to d47c52b Compare August 10, 2022 10:41
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #64039 succeeded 2774435e5577323b2dd9a778c0f4f981506af7ca

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@banderror banderror merged commit 5a24ba3 into elastic:main Aug 10, 2022
@kibanamachine kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Aug 10, 2022
@banderror banderror deleted the unskip-tests-for-bulk-editing-index-patterns branch August 10, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadameSheema MadameSheema MadameSheema approved these changes

@jpdjere jpdjere jpdjere approved these changes

Assignees

@banderror banderror

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.0
Projects
None yet
Milestone
No milestone
6 participants
@banderror @elasticmachine @kibana-ci @jpdjere @MadameSheema @kibanamachine