-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gridster with react-grid-layout #13853
Merged
stacey-gammon
merged 32 commits into
elastic:master
from
stacey-gammon:react/replace-dashboard-grid
Sep 26, 2017
Merged
Changes from 19 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
aafbe72
Initial check-in to replace gridster with react-grid-layout and react…
stacey-gammon bee007f
# This is a combination of 3 commits.
stacey-gammon 75075c2
Add margin of error to test determining panel widths
stacey-gammon e0321be
Remove unnecessary _.once when creating react directives in dashboard.js
stacey-gammon e58ac8d
Remove unnecessary constructors
stacey-gammon 1f70da2
Use componentDidMount instead of componentWillMount bc of async calls…
stacey-gammon 7003150
Remove unnecessary null in classNames
stacey-gammon 4114236
Use loads defaultsDeep instead of Object.assign
stacey-gammon 5064127
use render* instead of get* for functions returning an element
stacey-gammon 0e85f7c
use relative css paths
stacey-gammon 6d10b5a
Use local import path
stacey-gammon f61e268
Switch to local imports and remove need for plugins path in jest tests
stacey-gammon f7347dd
Improve accessibility of max/min panel toggle icon
stacey-gammon fca9d0d
remove unused css
stacey-gammon 6290a44
disable eslint rule for setState in componentDidMount
stacey-gammon efa50d7
Use native map instead of lodash
stacey-gammon bc73ef8
Have the grid handle setting the z-indexes of the right reactgriditem
stacey-gammon c81a918
Make the draggable handle the title, not the whole heading
stacey-gammon f71a249
Change from click to mouse down detector in KuiOutsideClickDector so …
stacey-gammon 4cd1a9e
Fix mistaken commit
stacey-gammon 5df16d3
Run getEditPath and getTitle async calls in parallel - no need to wai…
stacey-gammon 46f89a0
Fix tests: update snapshots, add promise returns.
stacey-gammon dff702b
Merge branch 'master' of https://github.com/elastic/kibana into react…
stacey-gammon 794aa02
version being added to panelData in the wrong spot caused isDirty fla…
stacey-gammon 58aed06
Fix unmounting/mounting problem with panels due to view/edit mode switch
stacey-gammon 4cb254d
Fix bug where panels get squashed to one side when view mode is chang…
stacey-gammon 5553c04
Update snapshots to match wrong view mode comparison
stacey-gammon 5a93c30
Improve naming of a variable
stacey-gammon 3fc09aa
Fix issue with pop over hiding behind tile maps
stacey-gammon 7f0d72f
Previous panel.js included ui/doc_table and ui/visualize - needed to …
stacey-gammon 5481807
Merge with master
stacey-gammon bb15fb2
Fix bad merge: remove baseline screenshots
stacey-gammon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 0 additions & 126 deletions
126
src/core_plugins/kibana/public/dashboard/__tests__/dashboard_panels.js
This file was deleted.
Oops, something went wrong.
79 changes: 0 additions & 79 deletions
79
src/core_plugins/kibana/public/dashboard/__tests__/panel.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,9 @@ export const DashboardConstants = { | |
LANDING_PAGE_PATH: '/dashboards', | ||
CREATE_NEW_DASHBOARD_URL: '/dashboard', | ||
}; | ||
export const DEFAULT_PANEL_WIDTH = 6; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I moved these in here because now |
||
export const DEFAULT_PANEL_HEIGHT = 3; | ||
export const DASHBOARD_GRID_COLUMN_COUNT = 12; | ||
|
||
export function createDashboardEditUrl(id) { | ||
return `/dashboard/${id}`; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switched to getContainerApi instead of passing containerApi in directly to avoid circular references.