Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump undici sub-dependency from v5.5.1 to v5.8.2 #138877

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Conversation

watson
Copy link
Contributor

@watson watson commented Aug 16, 2022

Note to reviewers

Before adding the commit 9fa9227 and f55c5a0 to this PR, a lot of the tests failed with this error message:

ReferenceError: AbortSignal is not defined
  at Object.<anonymous> (node_modules/undici/lib/fetch/request.js:839:3)
  at Object.<anonymous> (node_modules/undici/index.js:99:28)

I boiled it down to this combo:

  • Running jest pre v27
  • Having testEnvironment: 'node' in the jest config
  • Referencing the AbortSignal object somewhere in the test path

If you remove testEnvironment: 'node' (as I do in 9fa9227 and f55c5a0) or upgrade to jest v27 or newer (see jestjs/jest#11182), the error goes away.

However, when trying to replicate this issue in an isolated environment I was not able to make the issue go away by simply removing testEnvironment: 'node'. So there's something in our particular jest config that somehow avoids this problem when testEnvironment is not set (but we're not alone). So while the default of testEnvironment is node according to the docs and so removing this line shouldn't make a difference, our setup might so different from a regular setup that there's unforeseen side effects by removing testEnvironment: 'node'. So upgrading to jest v27 or newer is probably the best thing to do.

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Aug 16, 2022
@watson watson self-assigned this Aug 16, 2022
@watson watson requested a review from a team August 16, 2022 09:09
@watson watson enabled auto-merge (squash) August 16, 2022 09:15
@watson watson requested a review from a team as a code owner August 22, 2022 13:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson merged commit 84e8e54 into elastic:main Aug 23, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2022
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Upgrade micromatch from v3.1.10 to v4.0.5 (#139187)
8.3
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 138877

Questions ?

Please refer to the Backport tool documentation

@watson watson added v8.3.4 v8.4.1 and removed backport:all-open Backport to all branches that could still receive a release labels Aug 23, 2022
@watson
Copy link
Contributor Author

watson commented Aug 23, 2022

No need to backport to 7.17 as undici isn't used there.

@watson watson deleted the bump-undici branch August 23, 2022 14:40
kibanamachine added a commit that referenced this pull request Aug 23, 2022
(cherry picked from commit 84e8e54)

Co-authored-by: Thomas Watson <watson@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 23, 2022
(cherry picked from commit 84e8e54)

Co-authored-by: Thomas Watson <watson@elastic.co>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.3.4 v8.4.0 v8.4.1 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants