-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump undici sub-dependency from v5.5.1 to v5.8.2 #138877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @watson |
spalger
approved these changes
Aug 23, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2022
(cherry picked from commit 84e8e54)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2022
(cherry picked from commit 84e8e54)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
No need to backport to |
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2022
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2022
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers
Before adding the commit 9fa9227 and f55c5a0 to this PR, a lot of the tests failed with this error message:
I boiled it down to this combo:
testEnvironment: 'node'
in the jest configAbortSignal
object somewhere in the test pathIf you remove
testEnvironment: 'node'
(as I do in 9fa9227 and f55c5a0) or upgrade to jest v27 or newer (see jestjs/jest#11182), the error goes away.However, when trying to replicate this issue in an isolated environment I was not able to make the issue go away by simply removing
testEnvironment: 'node'
. So there's something in our particular jest config that somehow avoids this problem whentestEnvironment
is not set (but we're not alone). So while the default oftestEnvironment
isnode
according to the docs and so removing this line shouldn't make a difference, our setup might so different from a regular setup that there's unforeseen side effects by removingtestEnvironment: 'node'
. So upgrading to jest v27 or newer is probably the best thing to do.