[APM] Mock synthetic source for metric documents #139643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
dgieselaar
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
gbamparop
reviewed
Aug 30, 2022
| prefix: string = '' | ||
| ) { | ||
| for (const key in source) { | ||
| if (!Object.hasOwn(source, key)) { |
There was a problem hiding this comment.
Nice, prob a good idea to replace server-side hasOwnProperty calls as well at some point
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Oct 11, 2022
)" This reverts commit 1def7cb.
sorenlouv
added a commit
that referenced
this pull request
Oct 11, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2022
)" (elastic#143027) This reverts commit 1def7cb. (cherry picked from commit 8c38609)
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocks synthetic source for metric documents in the APM event client to ensure compatibility when synthetic source is enabled.