Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Stats API for 6.0 #13969

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Revert Stats API for 6.0 #13969

merged 1 commit into from
Sep 20, 2017

Conversation

tsullivan
Copy link
Member

Backport of #13896 for 6.0

Since there is no server method in 6.0 (the server method is 6.1+), this change is a removal of the whole stats module.

Related: #11992 (comment)

@tsullivan tsullivan mentioned this pull request Sep 12, 2017
Merged
@jbudz
Copy link
Member

jbudz commented Sep 18, 2017

jenkins, test it

@tsullivan
Copy link
Member Author

Blocked by TypeError: Cannot read property 'some' of undefined in "Controller passes partialRows:true to tabify based on the vis params" test

stacey-gammon
stacey-gammon approved these changes Sep 20, 2017
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye bye stats

@tsullivan
Copy link
Member Author

bye bye stats

Just the HTTP endpoint :)

Thanks!

@tsullivan tsullivan merged commit b4d2e5b into elastic:6.0 Sep 20, 2017
@tsullivan tsullivan deleted the revert/stats-api-6.0 branch September 20, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
review v6.0.0-rc1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsullivan @jbudz @stacey-gammon @jimgoodwin