Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add one click filter to Lens table #139701

Merged
merged 4 commits into from
Sep 5, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #102115

By adding an option "Directly filter on click" to the "rows" columns :
Screenshot 2022-08-30 at 12 54 47

If set, the cell content will be rendered as an EuiLink and clicking it will directly apply the filter:

Default:
Screenshot 2022-08-30 at 12 56 01

With new setting:
Screenshot 2022-08-30 at 12 55 54

This can be used on dashboards with drilldowns as well, so the user doesn't have to hover, find the "plus" icon, click it to get to the drilldown context menu.

@flash1293 flash1293 added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting labels Aug 30, 2022
@flash1293 flash1293 marked this pull request as ready for review August 30, 2022 15:10
@flash1293 flash1293 requested a review from a team as a code owner August 30, 2022 15:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / spaces api with security resolve copy to spaces conflicts user with no access from the default space single-namespace types "before each" hook for "should return 403 when not overwriting, with references"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +995.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 34.6KB 34.7KB +43.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested it with all the breakdown types and it works as expected! Very nice enhancement :)

@flash1293 flash1293 merged commit c72e6ee into elastic:main Sep 5, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
* add one click filter to Lens table

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Allow cell contents to be clickable when drilldowns are enabled
5 participants