Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip filter panel a11y test suite #139834

Merged
merged 17 commits into from
Sep 19, 2022
Merged

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Aug 31, 2022

For issue - #139659 - unskip filter panel test with a slight refactoring

@bhavyarm bhavyarm self-assigned this Aug 31, 2022
@bhavyarm bhavyarm added Project:Accessibility Feature:Filters release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team labels Aug 31, 2022
@bhavyarm bhavyarm changed the title Unskip filter panel a11y test suite and skip unpin filters test which is failing Unskip filter panel a11y test suite Sep 7, 2022
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Sep 7, 2022

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Sep 7, 2022

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Sep 8, 2022

@bhavyarm
Copy link
Contributor Author

Removed unnecessary component tests for doing actions on apply to all panel.
Also figured out why the test was failing. The saved panel dts had to be clicked twice because of focus. thanks @dmlemeshko

await testSubjects.click('queryBarMenuPopover');

@bhavyarm bhavyarm force-pushed the unskipFilterPanelTests branch from 59590f4 to 0653295 Compare September 19, 2022 18:29
@bhavyarm
Copy link
Contributor Author

@bhavyarm bhavyarm marked this pull request as ready for review September 19, 2022 19:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm requested review from LeeDr and 1Copenut September 19, 2022 19:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Bhavya and I had a quick video call and she showed me the use cases under test and her reasoning for removing the individual tests. We're testing the component and its constituent behaviors in EUI, so focusing on the saved query and apply all cases make sense here.

@bhavyarm bhavyarm added v8.5.0 backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Sep 19, 2022
@bhavyarm bhavyarm merged commit a823c38 into elastic:main Sep 19, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 19, 2022
(cherry picked from commit a823c38)

Co-authored-by: Bhavya RM <bhavya@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:Filters Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v8.4.2 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants