-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip filter panel a11y test suite #139834
Conversation
Flaky run with sleep - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1160 |
Third flaky test run - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1174 |
Removed unnecessary component tests for doing actions on apply to all panel.
|
59590f4
to
0653295
Compare
Flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1241 |
Pinging @elastic/kibana-qa (Team:QA) |
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @bhavyarm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Bhavya and I had a quick video call and she showed me the use cases under test and her reasoning for removing the individual tests. We're testing the component and its constituent behaviors in EUI, so focusing on the saved query and apply all cases make sense here.
(cherry picked from commit a823c38)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
For issue - #139659 - unskip filter panel test with a slight refactoring