-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Support Input Packages #140035
[Fleet] Support Input Packages #140035
Conversation
026798e
to
fac6636
Compare
fe1f386
to
a52ea39
Compare
e78a688
to
aa9e602
Compare
@elasticmachine merge upstream |
… into 137750-support-input-pkgs
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Hi @hop-dev @jen-huang, We have re-validated this ticket on the latest 8.6.0 BC1 Kibana Self-managed environment and found the below observations. Build details:
Below are the observations:
Screenshot: Hence, marking this ticket as QA: Validated. Please let us know if we are missing anything. Thanks! |
Hi Prachi, there is a further test step to be performed to confirm that data is generated. Something like:
|
Hi @hop-dev, We were setting up the environment to check the custom logs on Kibana on Ubuntu machine but Kibana is not getting launched after running the registry command.
Please find the below steps performed on setting up the environment:
Could you please confirm is there any other way to setup the environment other than Please let us know if we are missing anything. QueriesCould you please confirm the following:
Thanks! |
## Summary Closes #145903 Added datasets combo box to input type packages `Dataset name` variable with the option of creating a new one. Using the existing `/data_streams` API to show the list of all datasets. Package policy create/edit API already supports setting the value of `data_stream.dataset` (input packages should have this variable as described in #133296) To verify: - Start local EPR with input type packages as described [here](#140035 (comment)) - Add `Custom Logs` integration - Verify that Dataset name displays a dropdown and the selected value is persisted. - Verify that a new value can be entered in Dataset name - Verify that Edit integration policy displays the existing value and allows selecting/creating another one. <img width="924" alt="image" src="https://user-images.githubusercontent.com/90178898/205680787-3ef7da08-f5f0-4f05-b8d7-3a1c0a6a3d56.png"> <img width="1008" alt="image" src="https://user-images.githubusercontent.com/90178898/205679497-935fe450-ce78-4f0b-943e-58e7f851f44b.png"> <img width="1006" alt="image" src="https://user-images.githubusercontent.com/90178898/205679589-fedbbe0e-2c4d-4c00-986f-34ec5c2eb2f6.png"> Added ordering of datasets to move up those that start with the package name e.g. `system*` datasets come first if adding a `system` integration. Other than that ordering datasets alphabetically. <img width="482" alt="image" src="https://user-images.githubusercontent.com/90178898/205924837-a9807c92-2fe4-431a-88c6-f161d00812fb.png"> The rest of the requirements seem to be already implemented, see [comments](#145903 (comment)) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@jen-huang can someone answer the QA team's questions at the end of the comment above? |
Tagging @hop-dev for reviewing these Qs |
Input packages will allow the user to customise their ingest a lot more than a traditional 'integration' package. For example, an integration package defines the inputs (where the data comes from) and the data streams (how the data is stored in elastic) whereas input packages only define the input, allowing us to create the data stream dynamically and give the user more configuration options. As we are only at phase q a lot of this configuration is not available yet, (see the fleet parent issue for more info on where we are heading with this) This is why at the moment the testing focuses on input packages working the same as the existing integration packages, but behind the scenes the implementation has quite a few differences. More reading:
As there are no input only packages released on the package registry I dont believe we can test this on cloud yet
Yes I believe so, however it may be premature to add this until an input only package is released? The test setup at the moment is quite labour intensive. @jen-huang do you agree? |
@prachigupta-qasource it looks like your elasticsearch was unhealthy from the screenshots, I would recommend wiping your elasticsearch and trying again. Happy to jump on a zoom call and debug some time? so sorry about the delayed reply! |
Hi @hop-dev We have revalidated this feature on latest 8.6 BC10 kibana self-managed environment and found had below observations.
Build details: Screen Recording: Amol-Chas_Ubuntu-20.-.Google.Chrome.2023-01-09.12-28-50.mp4Hence, marking this as QA:Validated. Please let us know if anything else is required from our end. Thanks |
Hi @hop-dev Could you please confirm if we need to add this feature for testing in our regression cycle. Thank you. |
Hi @amolnater-qasource, I think we do want to add it yes as going forward input packages will be quite important to the fleet user experience, however I understand not having input packages readily available makes the testing of this feature a bit more involved. @kpollich do you agree we should add this to the regression tests? |
Yes, please add to regression tests. |
Thank you for confirming.
Please let us know if any other scenario needs to be covered. |
Summary
Part of #137750.
Add support for the installation of input only packages. Current caveats to be addressed in later PRs before release goes out:
What is an input only package (high level)?
Input only packages have
type : input
as part of the manifest.Input only packages do not define the stream as part of the package definition only the input. This means that we have to build the data stream as part of package policy creation.
Test instructions
Download the test data zip:
input-packages.zip
Start a registry:
custom_logs
andsql_input
input integrations are now available for install (custom logs is a good test package as it behaves exactly the same as the logs integration) for example custom_logs integration can be found at<your kibana URL>/app/integrations/detail/custom_logs-1.0.0/overview
:Checklist
Delete any items that are not applicable to this PR.