[6.x]Input Control visualization #14074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* react editor example * ensure props are not updated * use new stageEditorParams method to stage parameter changes * make component stateless * use terms_vis_editor component * get add button to work * update vis controller to display terms input controls * update componenent when query bar updates * add functional test * lay ground work for different control types in single visulization * make editors for range and text controls * text control * implement type ahead suggestor for text control * add range slider * some CSS work * add submit button, move control init functionallity under control_factory * add custom options for control types * provide buttons to move controls up and down * Make ControlEditor component and clean up styling of editor * styling work * multi select for terms dropdown control * add option to disable filter staging, only enable submit button when filters are staged * clean up range styling * rename top level vis folder * cleanup * move control type select out of each control editor * dark theme styling * use ui/public/filter_manager/lib/phrases.js to build phrases filter, add tests to range filter manager * use savedObjectsClient to get index patterns * remove text control and add id to controls for react tracking * ensure fields get updated when index pattern changes * update PropTypes for react 15.6.1 * update to latest react-select to avoid isMounted deprecation warnings * fix input controls functional test * rename termsControl to listControl to be more generic * add function test for clear button, refactor directory structure * functional tests for updateFiltersOnChange is true * fix react-select clipping problem in dashboard * try clicking option instead of pressing enter to set react-select value in functional tests * react-select css * clean up control_editor component, make ListControlEditor component be function * add jest test for vis_editor component and accessibility * add decimal places option to range slider * add jest test for InputControlVis component * add default to switch blocks, split editor into seperate tabs, use shallow in snapshot tests * fix race condition in field_select, update index_pattern_select to fetch indexPatterns on each filter * clean up control initialization * use htmlIdGenerator to avoid html element id conflicts * update functional test to support new editor tabs * finish jest tests for sub componenets * mark vis as experimental, refactor buttons for better usability * fix bug in list control where unable to select options containing numbers and options containing commas. Truncate display of long list options * fix chart types functional test * fix jest tests, add margin to action buttons * remove binds from render functions * experement with native input range sliders * Revert "experement with native input range sliders" This reverts commit aed599e. * Use Promise.resolve in tests and replace _createRequest with searchSource.fetch * add inputs to range control
|
This represents is a turning point for kibana. How about merging this into 6.0 too? |
|
6.0 is already in the release candidate phase and new features can not be merged into the baseline. |
|
pity! :) Any plan to have a plain "search widget" too? embed mode doesn't allow free search. |
|
no plans yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #13314