Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: Fix frequent_items agg config. #140814

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

walterra
Copy link
Contributor

Summary

Part of #138117.

  • Tweaks the frequent_items agg config. should_minimum_match:2 for the terms should clause improves getting back groups of results. minimum_set_size:2 will avoid single item frequent sets.
  • Passes on a possible filter bar query to the frequent_items agg.

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis labels Sep 15, 2022
@walterra walterra self-assigned this Sep 15, 2022
@walterra walterra requested a review from a team as a code owner September 15, 2022 13:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@walterra walterra merged commit 2c2c0c0 into elastic:main Sep 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 15, 2022
@walterra walterra deleted the ml-aiops-api-grouping-tweaks-1 branch September 15, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants