Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: Fix flaky wizard functional tests. #141209

Merged
merged 4 commits into from
Sep 22, 2022
Merged

[ML] Transforms: Fix flaky wizard functional tests. #141209

merged 4 commits into from
Sep 22, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Sep 21, 2022 •
edited by kibanamachine
Loading

Summary

Fixes error seen in #139781:

fail: transform creation_index_pattern batch transform with terms+date_histogram groups and avg agg navigates through the wizard and sets all needed fields
--
  | │      StaleElementReferenceError: stale element reference: element is not attached to the page document
  | │   (Session info: headless chrome=104.0.5112.101)

This replaces clickWhenNotDisabledWithoutRetry with clickWhenNotDisabled to stabilize tests.

Related ML issue: #140326 (comment)

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v8.5.0 labels Sep 21, 2022
@walterra walterra self-assigned this Sep 21, 2022
@walterra walterra mentioned this pull request Sep 21, 2022
Closed
19 tasks
@walterra
Copy link
Contributor Author

walterra commented Sep 21, 2022 •
edited
Loading

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1264

✅ 100 runs passed!

@walterra walterra force-pushed the ml-139781-transform-stabilize-functional-tests branch from e642f55 to e2cb23f Compare September 21, 2022 15:58
@walterra walterra marked this pull request as ready for review September 21, 2022 15:59
@walterra walterra requested a review from a team as a code owner September 21, 2022 15:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #74369 succeeded e642f556813e6a322fad989f173226037f8e543b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra
Copy link
Contributor Author

walterra commented Sep 21, 2022 •
edited
Loading

Flaky Test Runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1280

✅ 100 runs passed!

pheyos
pheyos approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit d078d81 into elastic:main Sep 22, 2022
@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 22, 2022
@walterra walterra deleted the ml-139781-transform-stabilize-functional-tests branch September 22, 2022 08:26
@kibanamachine kibanamachine mentioned this pull request Sep 22, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2022
@walterra
[ML] Transforms: Fix flaky wizard functional tests. (elastic#141209)
363a4c4 
This replaces clickWhenNotDisabledWithoutRetry with clickWhenNotDisabled to stabilize tests.

(cherry picked from commit d078d81)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Sep 22, 2022
@walterra
[ML] Transforms: Fix flaky wizard functional tests. (#141209)
46ca338 
This replaces clickWhenNotDisabledWithoutRetry with clickWhenNotDisabled to stabilize tests.

(cherry picked from commit d078d81)
@kibanamachine kibanamachine mentioned this pull request Sep 22, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Sep 22, 2022
@kibanamachine @walterra
[ML] Transforms: Fix flaky wizard functional tests. (#141209) (#141355)
6f08595 
This replaces clickWhenNotDisabledWithoutRetry with clickWhenNotDisabled to stabilize tests.

(cherry picked from commit d078d81)

Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
kibanamachine added a commit that referenced this pull request Sep 22, 2022
@kibanamachine @walterra
[ML] Transforms: Fix flaky wizard functional tests. (#141209) (#141357)
74e8660 
This replaces clickWhenNotDisabledWithoutRetry with clickWhenNotDisabled to stabilize tests.

(cherry picked from commit d078d81)

Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
@pheyos pheyos mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@walterra walterra

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson