Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: Preserves the field for unsupported aggs #142106

Merged
merged 3 commits into from
Sep 30, 2022
Merged

[ML] Transforms: Preserves the field for unsupported aggs #142106

merged 3 commits into from
Sep 30, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Sep 28, 2022 •
edited by kibanamachine
Loading

Summary

Fixes #132523

Preserves the field for unsupported aggs.

Sep-28-2022 15-30-49

Checklist

@darnautov darnautov self-assigned this Sep 28, 2022
@darnautov darnautov requested a review from a team as a code owner September 28, 2022 13:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, also did a local test.

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@peteharverson peteharverson mentioned this pull request Sep 29, 2022
Closed
19 tasks
peteharverson
peteharverson approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.
Great to see the new test to verify the fix!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 388.3KB 388.3KB +55.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@peteharverson peteharverson changed the title [ML] Preserves the field for unsupported aggs [ML] Transforms: Preserves the field for unsupported aggs Sep 30, 2022
@darnautov darnautov merged commit 2d8eb0e into elastic:main Sep 30, 2022
@darnautov darnautov deleted the ml-132523-fix-advanced-agg branch September 30, 2022 09:22
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2022
@darnautov
[ML] Transforms: Preserves the field for unsupported aggs (elastic#…
3c2adc0 
…142106)

* preserve field for unsupported agg

* add unit test

(cherry picked from commit 2d8eb0e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 30, 2022
@kibanamachine @darnautov
[ML] Transforms: Preserves the field for unsupported aggs (#142106) (…
c91162f 
…#142309)

* preserve field for unsupported agg

* add unit test

(cherry picked from commit 2d8eb0e)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 2, 2022
@darnautov @WafaaNasr
[ML] Transforms: Preserves the field for unsupported aggs (elastic#…
4d98e2b 
…142106)

* preserve field for unsupported agg

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
Feature:Transforms ML transforms :ml release_note:fix Team:ML Team label for ML (also use :ml) v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Transforms: Editing the name of an advanced aggregation clears the field name
6 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @walterra @peteharverson