Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] api/ml/jobs/jobs api tests #142234

Merged
merged 2 commits into from
Sep 30, 2022
Merged

[ML] api/ml/jobs/jobs api tests #142234

merged 2 commits into from
Sep 30, 2022

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 29, 2022 •
edited by kibanamachine
Loading

Adds a test which calls /api/ml/jobs/jobs and confirms that it contains jobs, jobs stats, datafeeds, datafeed stats and calendars.
Also adds jobs to a different space and ensures jobs in default space and specific space are correct.

Part of #137573

@jgowdyelastic jgowdyelastic changed the title [ML] /api/ml/jobs/jobs api tests [ML] api/ml/jobs/jobs api tests Sep 29, 2022
@jgowdyelastic jgowdyelastic self-assigned this Sep 29, 2022
@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0 labels Sep 29, 2022
@jgowdyelastic jgowdyelastic marked this pull request as ready for review September 29, 2022 15:39
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 29, 2022 15:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic mentioned this pull request Sep 29, 2022
Closed
19 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson
peteharverson approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pheyos
pheyos approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit a1759bd into elastic:main Sep 30, 2022
@jgowdyelastic jgowdyelastic deleted the jobs/jobs-api-tests branch September 30, 2022 09:55
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2022
@jgowdyelastic
[ML] api/ml/jobs/jobs api tests (elastic#142234)
0f50193 
* [ML] /api/ml/jobs/jobs api tests

* adding space tests

(cherry picked from commit a1759bd)
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 30, 2022
@kibanamachine @jgowdyelastic
[ML] api/ml/jobs/jobs api tests (#142234) (#142316)
d713014 
* [ML] /api/ml/jobs/jobs api tests

* adding space tests

(cherry picked from commit a1759bd)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 2, 2022
@jgowdyelastic @WafaaNasr
[ML] api/ml/jobs/jobs api tests (elastic#142234)
6d992ea 
* [ML] /api/ml/jobs/jobs api tests

* adding space tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson