-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] layer groups #142528
[Maps] layer groups #142528
Conversation
…-ref HEAD~1..HEAD --fix'
@elasticmachine merge upstream |
x-pack/plugins/maps/public/components/remove_layer_confirm_modal.tsx
Outdated
Show resolved
Hide resolved
…al.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
code review and tested in chrome
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@mdefazio let me know if you have any more feedback. We plan on refining the UI with follow up PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Happy to help in some follow-up PRs to add in some UI details to improve this, but I don't think these are blockers.
Pinging @elastic/kibana-presentation (Team:Presentation) |
Fixes #37252
PR enhances Map legend, allowing users to group layers into tree view. PR updates remove layer action with a modal ensuring users are aware that removing a layer group will also remove all sub layers.
Create layer group
Click the grab handle to the right of layer in the legend and hold the mouse button to initiate dragging. Then, drag the layer until it over laps with another layer. The layer will become semi-transparent and the mouse cursor will change to indicate when in "combining" state. Let go of the mouse button and a new layer group will be created that contains the 2 layers.
Move layer group
Layer groups can be re-ordered like any layer by dragging the "reorder" handle in the legend. Re-ordering a layer group will also move all sublayers to new tree location. Layer groups cannot be moved into their ancestry chain.
Move a layer into a layer group
There are 2 ways to move a layer into a layer group. Do one of the following:
Move a layer out of a layer group
Follow up work
This PR is getting very large, so the following items have been excluded to follow up PRs