Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Use createPointInTimeFinder to fetch savedObjects in sync #142640

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 4, 2022

Summary

Use createPointInTimeFinder to fetch savedObjects in sync.

This will make sure sync is not limited to 10k saved objects.

@shahzad31 shahzad31 marked this pull request as ready for review October 4, 2022 19:14
@shahzad31 shahzad31 requested a review from a team as a code owner October 4, 2022 19:14
@shahzad31 shahzad31 added v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 4, 2022
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working as expected. Works for both syncing monitors and test-now/run once.

@shahzad31 shahzad31 merged commit 161d8b9 into elastic:main Oct 14, 2022
@shahzad31 shahzad31 deleted the batch-sync branch October 14, 2022 07:19
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 14, 2022
@shahzad31
Copy link
Contributor Author

Skipping testing as it's only technical change !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants