[Infrastructure UI] Replace Lens table with EUI table and own api #142871

neptunian · 2022-10-06T15:00:20Z

This PR replaces the lens component with eui table using snapshot API. The time range implementation will be added as part of the filtering implementation (It's hardcoded for now). Services on Host and Disk Latency will be implemented in separate issues.

Testing

Metricbeats - if you want to test the table using metricbeat add :
```
     processors:
       - add_host_metadata: ~
```
to your metricbeat config to get the Operating System value
Slingshot - The OS value won't appear in the table because slingshot is not adding os.name value to the generated hosts
The time range inside hosts_content.tsx should be adjusted based on the test data ( I went to the Inventory page and coppied the time range values from the request there to make sure I have the same data )
I tested with both (Metricbeats and Slingshot) locally and was able to see the data in the table:

neptunian · 2022-10-06T19:57:19Z

x-pack/plugins/infra/kibana.json

@@ -15,8 +15,7 @@
    "triggersActionsUi",
    "observability",
    "ruleRegistry",
-    "unifiedSearch",
-    "lens"


we might want to leave this for now as we are thinking to use Lens Embeddables for other things. or we can remove it and just add it back later.

neptunian · 2022-10-06T19:57:38Z

x-pack/plugins/infra/public/types.ts

@@ -75,7 +74,6 @@ export interface InfraClientStartDeps {
  embeddable?: EmbeddableStart;
  osquery?: unknown; // OsqueryPluginStart;
  share: SharePluginStart;
-  lens: LensPublicStart;


we might want to leave this for now as we are thinking to use Lens Embeddables for other things. or we can remove it and just add it back later.

x-pack/plugins/infra/common/inventory_models/host/metrics/snapshot/memory_total.ts

jennypavlova · 2022-10-14T17:31:55Z

x-pack/plugins/translations/translations/fr-FR.json

+    "xpack.infra.hostsTable.nameColumnHeader": "Nom",
+    "xpack.infra.hostsTable.operatingSystemColumnHeader": "Système d'exploitation",
+    "xpack.infra.hostsTable.numberOfCpusColumnHeader": "Nombre de processeurs",
+    "xpack.infra.hostsTable.diskLatencyColumnHeader": "",


Note: Those translations are missing (couldn't find them in the project so I guess they should be added)

jennypavlova · 2022-10-14T17:39:53Z

x-pack/plugins/infra/public/pages/metrics/hosts/hosts_content.tsx

+    '',
+    '',
+    true,
+    {


Regarding the dynamic time range, we discussed with @crespocarlos that it will be better to be added as part of the filter issue and maybe after we have the url state implemented so we will have a clear scope of this issue (replacement of the lens table with eui table) and it will unblock the other issues where we need the table to be changed. What do you think?

It makes more sense to address this on the unified search ticket. Everything related to filter is connected to that.

x-pack/plugins/infra/public/pages/metrics/hosts/components/hosts_table.tsx

…ge values

elasticmachine · 2022-10-18T15:14:15Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

crespocarlos · 2022-10-20T09:06:19Z

x-pack/plugins/infra/public/pages/metrics/hosts/components/hosts_table.tsx

-  } as TypedLensByValueInput['attributes']);
+import React from 'react';
+import { EuiBasicTable } from '@elastic/eui';
+import { SnapshotNode } from '../../../../../common/http_api';


How about

Suggested change

import { SnapshotNode } from '../../../../../common/http_api';

import type { SnapshotNode } from '../../../../../common/http_api';

crespocarlos

Cool stuff! Just left a few minor comments.

I wonder whether we should prompt users to enable the add_host_metadata in case the OS info is missing. But his would be another ticket anyways

crespocarlos · 2022-10-20T09:08:02Z

x-pack/plugins/infra/public/pages/metrics/hosts/components/hosts_table_columns.tsx

+import { i18n } from '@kbn/i18n';
+import { EuiText } from '@elastic/eui';
+import { scaleUpPercentage } from '../../../../components/infrastructure_node_metrics_tables/shared/hooks';
+import { SnapshotNodeMetric } from '../../../../../common/http_api/snapshot_api';


nit (we're just importing a type here):

Suggested change

import { SnapshotNodeMetric } from '../../../../../common/http_api/snapshot_api';

import type { SnapshotNodeMetric } from '../../../../../common/http_api/snapshot_api';

crespocarlos · 2022-10-20T09:23:48Z

x-pack/plugins/infra/public/pages/metrics/hosts/hooks/use_host_table.ts

+export const useHostTable = (nodes: SnapshotNode[]) => {
+  const items: MappedMetrics[] = useMemo(() => {
+    return nodes.map(({ metrics, path }) => ({
+      ...path[0],


What happens if path has more than 1 item? I don't think path could ever be null, right?

Good point, I don't think that's the case here - Based on what I see in applyMetadataToLastPath there should be only one document with metadata, there we use the last document to add the os - So we can do it similar to the idea there using last where we are setting the os we need here and even if there are other elements before we will get the correct one (the last one we used to add the os to).

crespocarlos · 2022-10-20T09:24:42Z

x-pack/plugins/infra/public/pages/metrics/hosts/hosts_content.tsx

 import { useSourceContext } from '../../../containers/metrics_source';
+import { useSnapshot } from '../inventory_view/hooks/use_snaphot';
+import { SnapshotMetricType } from '../../../../common/inventory_models/types';


nit (just type import):

Suggested change

import { SnapshotMetricType } from '../../../../common/inventory_models/types';

import type { SnapshotMetricType } from '../../../../common/inventory_models/types';

crespocarlos · 2022-10-20T09:25:36Z

x-pack/plugins/infra/server/routes/snapshot/lib/apply_metadata_to_last_path.ts

@@ -56,6 +56,10 @@ export const applyMetadataToLastPath = (
          lastPath.ip = ipAddresses;
        }
      }
+      if (inventoryFields.os) {
+        const inventoryFieldsOs = get(firstMetaDoc, inventoryFields.os) as string;


nit: we could maybe shorten this?

Suggested change

const inventoryFieldsOs = get(firstMetaDoc, inventoryFields.os) as string;

lastPath.os = get(firstMetaDoc, inventoryFields.os) as string;

Good idea, thanks 🙂 Done ✅

crespocarlos · 2022-10-20T09:26:44Z

x-pack/plugins/infra/public/pages/metrics/hosts/hooks/use_host_table.test.ts

@@ -0,0 +1,126 @@
+/*


Nice! :)

Maybe it would be good to validate when path has more than 1 item (I'm not sure when this case would actually happen in real life though)

As I checked the in applyMetadataToLastPath we will use the last element so I will update one of the items to have 2 elements in the path and check that we use only the last.

kibana-ci · 2022-10-24T07:28:31Z

💚 Build Succeeded

Buildkite Build
Commit: 3423b70

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1008	1012	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.0MB	1009.4KB	-18.8KB

History

💚 Build #81853 succeeded 1a29df3
💚 Build #81755 succeeded 36a30da
💛 Build #81070 was flaky 4ecda79
💚 Build #80984 succeeded 263ee4d
💔 Build #80960 failed 191a3d0
💚 Build #80921 succeeded 13f8677

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

crespocarlos

LGTM!

* main: (57 commits) [Files] Filepicker (elastic#143111) [Infrastructure UI] Replace Lens table with EUI table and own api (elastic#142871) [api-docs] Daily api_docs build (elastic#143829) [api-docs] Daily api_docs build (elastic#143825) [api-docs] Daily api_docs build (elastic#143823) [Security Solution] Restructuring folders of Detection Engine + refactoring Rule Management (elastic#142950) [Dev tools] Fix performance issue with autocomplete suggestions (elastic#143428) [Security Solution] Disable ML rule's edit button link under basic license (elastic#143260) [Lens] Use the language-documentation package for formula (elastic#143649) [api-docs] Daily api_docs build (elastic#143811) [Security Solution] Fix missing title on inspect pop-up (elastic#143601) fix incorrect filters being passed to events table causing duplicate entries in our inpsect tool request tab (elastic#143239) [Security Solution][Endpoint] `get-file` response action kibana download file API (elastic#143708) Rely on refresh context to update stats independently of overview cards. (elastic#143308) [RAM] Rule event log - Fix incorrect results when filtering by message and outcome simultaneously (elastic#143119) [ML] Display link to create data view from error cases in data frame analytics results pages (elastic#143596) Update links in README :) (elastic#143675) Add more tests for ml_inference_logic (elastic#143764) skip failing test suite (elastic#143717) [DOCS] Add assignees to case APIs (elastic#143610) ...

neptunian added 3 commits October 6, 2022 10:59

remove lens, add snapshot api

f309f35

merge

3b99bb5

add no data

fc545f6

neptunian mentioned this pull request Oct 6, 2022

[Infrastructure UI] Replace Lens table with EUI table and own api #142797

Closed

neptunian commented Oct 6, 2022

View reviewed changes

jennypavlova added 2 commits October 10, 2022 10:44

Add cpu type

26710d6

[WIP] Add eui basic table and columns

5a212ca

jennypavlova force-pushed the example-snapshot-table branch from bbebaec to 5a212ca Compare October 11, 2022 16:09

jennypavlova added 3 commits October 12, 2022 14:24

[WIP] Add cpu cores and os

4d47a82

[WIP] Mapping data to the eui basic table format

20719b5

Add Memory Total

392e035

jennypavlova force-pushed the example-snapshot-table branch from ef705fe to 392e035 Compare October 13, 2022 09:59

jennypavlova added 8 commits October 13, 2022 17:52

Refactor host mapping and add types

d1b432d

Scale up memory usage percentage

72f9d8c

Make os optional in the model

a20a278

Text cells formatting

5309f1f

Change os.type to os.name

b5e6432

Move snapshot nodes mapping to a hook and test it

b54de0e

Add translation

4153f3b

Add fixed range and cleanup

5ae30be

jennypavlova reviewed Oct 14, 2022

View reviewed changes

x-pack/plugins/infra/common/inventory_models/host/metrics/snapshot/memory_total.ts Show resolved Hide resolved

jennypavlova reviewed Oct 14, 2022

View reviewed changes

x-pack/plugins/infra/public/pages/metrics/hosts/components/hosts_table.tsx Show resolved Hide resolved

jennypavlova added 5 commits October 18, 2022 10:13

Merge branch 'main' into example-snapshot-table

13f8677

Fix diskLatency field name

9ab9f8a

Merge branch 'main' into example-snapshot-table

191a3d0

Remove not existing showQueryBar prop from SearchBar and set time ran…

263ee4d

…ge values

Merge branch 'main' into example-snapshot-table

4ecda79

jennypavlova marked this pull request as ready for review October 18, 2022 15:13

jennypavlova requested a review from a team as a code owner October 18, 2022 15:13

jennypavlova added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Oct 18, 2022

jennypavlova self-assigned this Oct 18, 2022

jennypavlova added the release_note:skip Skip the PR/issue when compiling release notes label Oct 18, 2022

jennypavlova changed the title ~~remove lens, add snapshot api~~ Remove lens, add snapshot api Oct 18, 2022

jennypavlova changed the title ~~Remove lens, add snapshot api~~ [Infrastructure UI] Replace Lens table with EUI table and own api Oct 18, 2022

crespocarlos reviewed Oct 20, 2022

View reviewed changes

jennypavlova added 7 commits October 20, 2022 13:18

Use last path

f68a313

Test last path change

0d07ca1

Type imports

e1f58f1

Change the way lastPath.os is set

662c7ae

Type import

a4bd9a5

Merge branch 'main' into example-snapshot-table

d493a03

Merge branch 'main' into example-snapshot-table

36a30da

jennypavlova requested a review from crespocarlos October 20, 2022 12:50

jennypavlova added 2 commits October 20, 2022 18:39

Merge branch 'main' into example-snapshot-table

1a29df3

Merge branch 'main' into example-snapshot-table

3423b70

crespocarlos approved these changes Oct 24, 2022

View reviewed changes

jennypavlova merged commit ffc8fb9 into elastic:main Oct 24, 2022

kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 24, 2022

neptunian added the Epic: Host Observability label Nov 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infrastructure UI] Replace Lens table with EUI table and own api #142871

[Infrastructure UI] Replace Lens table with EUI table and own api #142871

neptunian commented Oct 6, 2022 •

edited by jennypavlova

Loading

neptunian Oct 6, 2022 •

edited

Loading

neptunian Oct 6, 2022 •

edited

Loading

jennypavlova Oct 14, 2022

jennypavlova Oct 14, 2022

crespocarlos Oct 20, 2022

elasticmachine commented Oct 18, 2022

crespocarlos Oct 20, 2022

crespocarlos left a comment

crespocarlos Oct 20, 2022

crespocarlos Oct 20, 2022

jennypavlova Oct 20, 2022

crespocarlos Oct 20, 2022

crespocarlos Oct 20, 2022

jennypavlova Oct 20, 2022

crespocarlos Oct 20, 2022

jennypavlova Oct 20, 2022

kibana-ci commented Oct 24, 2022

crespocarlos left a comment

	import { SnapshotNode } from '../../../../../common/http_api';
	import type { SnapshotNode } from '../../../../../common/http_api';

	import { SnapshotNodeMetric } from '../../../../../common/http_api/snapshot_api';
	import type { SnapshotNodeMetric } from '../../../../../common/http_api/snapshot_api';

	import { SnapshotMetricType } from '../../../../common/inventory_models/types';
	import type { SnapshotMetricType } from '../../../../common/inventory_models/types';

	const inventoryFieldsOs = get(firstMetaDoc, inventoryFields.os) as string;
	lastPath.os = get(firstMetaDoc, inventoryFields.os) as string;

[Infrastructure UI] Replace Lens table with EUI table and own api #142871

[Infrastructure UI] Replace Lens table with EUI table and own api #142871

Conversation

neptunian commented Oct 6, 2022 • edited by jennypavlova Loading

Testing

neptunian Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

neptunian Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Oct 18, 2022

Choose a reason for hiding this comment

crespocarlos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibana-ci commented Oct 24, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

crespocarlos left a comment

Choose a reason for hiding this comment

neptunian commented Oct 6, 2022 •

edited by jennypavlova

Loading

neptunian Oct 6, 2022 •

edited

Loading

neptunian Oct 6, 2022 •

edited

Loading