Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved objects extensions refactor merge #142878

Merged
merged 67 commits into from
Nov 18, 2022
Merged

Saved objects extensions refactor merge #142878

merged 67 commits into from
Nov 18, 2022

Commits on Oct 5, 2022

  1. Adds extensions and factories for these 

    Adds public types for extensions, temporarily omiting these from public mocks and saved objects service

Adds extensions to saved objects start contract, temporarily omitting them from the saved objects service start implementation

adding extensions to saved objects implementation

Still wip adding extensions and factories to implementation

more small changes

Starts removing wrappers

Updates saved objects service mock

Updates more types around extensions and wrappers removal

Adds saved objects extensions to plugin_context

Adds extensions mocks to public saved objects server mocks

Updates two more tests
    @TinaHeiligers
    TinaHeiligers committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e9f14d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Adds SO repo extensions, continues wrapper removal

    @jeramysoucy
    jeramysoucy committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    9386be3 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Adds ROC extension implementations, complete removal of SOC wrapper r… 

    …eferences. Functional unit tests passing.
    @jeramysoucy
    jeramysoucy committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    2f46222 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Removed unnecessary wrapper tests.

    @jeramysoucy
    jeramysoucy committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    06ca3e6 View commit details
    Browse the repository at this point in the history

  2. Removes wrapper references from secure spaces client. Moves extension… 

    … mocks to API server mocks package.
    @jeramysoucy
    jeramysoucy committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    72138ee View commit details
    Browse the repository at this point in the history

  3. Fix to setup spaces client - now references security extension

    @jeramysoucy
    jeramysoucy committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    1bcbbdc View commit details
    Browse the repository at this point in the history

  4. Resolves SO extension mock references.

    @jeramysoucy
    jeramysoucy committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    1f277e6 View commit details
    Browse the repository at this point in the history

  5. Fixes several jest tests to include expected calling parameters with … 

    …internal options.
    @jeramysoucy
    jeramysoucy committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    4fff618 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Fixes several unit tests, cleans up unused code and comments.

    @jeramysoucy
    jeramysoucy committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    c7c4d55 View commit details
    Browse the repository at this point in the history

  2. Merges changes in api integration tests

    @jeramysoucy
    jeramysoucy committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    a8eefce View commit details
    Browse the repository at this point in the history

  3. Fixes accidental overwrite of esArchiver replacement.

    @jeramysoucy
    jeramysoucy committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9935fef View commit details
    Browse the repository at this point in the history

  4. [CI] Auto-commit changed files from 'node scripts/eslint --no-cache -… 

    …-fix'
    @kibanamachine
    kibanamachine committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    3398a57 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    da05c66 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Fixes repo called to find_legacy_url_aliases and find_shared_origin_o… 

    …bjects by adding the new internalOptions parameter.
    @jeramysoucy
    jeramysoucy committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    dfaf90b View commit details
    Browse the repository at this point in the history

  2. Reordered testDataLoader calls to eliminate error when deleting objects.

    @jeramysoucy
    jeramysoucy committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e3b3fc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    0eeb94b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    fce0433 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c3484af View commit details
    Browse the repository at this point in the history

  3. Manually adds definitions missed by merge from main.

    @jeramysoucy
    jeramysoucy committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    896813b View commit details
    Browse the repository at this point in the history

  4. Additional manual merge of 'created at'

    @jeramysoucy
    jeramysoucy committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d831567 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Merges bulk delete with SO extensions. Updates extension test suites … 

    …with bulk delete tests.
    @jeramysoucy
    jeramysoucy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ca77b0a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Adds test case for partially authorized in find

    @jeramysoucy
    jeramysoucy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    087c3a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Adds test_helpers folder for commom test utilites.

    @jeramysoucy
    jeramysoucy committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    dbb01f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Matches authorization behavior of bulk delete to existing delete. Res… 

    …olves functional test failures for bulk delete.
    @jeramysoucy
    jeramysoucy committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    62c0ec1 View commit details
    Browse the repository at this point in the history

  2. Fixes bulk delete unit test based on changes to authz behavior.

    @jeramysoucy
    jeramysoucy committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    7f8b670 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into merge-saved-objects-extensions

    @jeramysoucy
    jeramysoucy committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    247de7b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    2d01e30 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Resolves issues with fleet tests when bulkDelete is called with an em… 

    …pty array of objects.
    @jeramysoucy
    jeramysoucy committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    3192709 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactor-update_object_spaces' of https://github.com/Ti… 

    …naHeiligers/kibana into merge-saved-objects-extensions
    @jeramysoucy
    jeramysoucy committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    e8c4840 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    1307b79 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    2c45408 View commit details
    Browse the repository at this point in the history

  5. Fixes local types check issue

    @jeramysoucy
    jeramysoucy committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    0cbd92a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Adds missing TS docs - round 1

    @jeramysoucy
    jeramysoucy committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    b79b1b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Adds missing TSDoc comments - round 2. Removes redundant ISavedObject… 

    …sRepository definition from repository.
    @jeramysoucy
    jeramysoucy committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    33cb8e4 View commit details
    Browse the repository at this point in the history

  2. Removes 'import type' in so package domain. Updates mocks for find sh… 

    …ared origin objects and find legacy url aliases tests to remove reference to repository mock. Refactor of scoped client provider getExensions.
    @jeramysoucy
    jeramysoucy committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    6a586e3 View commit details
    Browse the repository at this point in the history

  3. [CI] Auto-commit changed files from 'node scripts/eslint --no-cache -… 

    …-fix'
    @kibanamachine
    kibanamachine committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    7472293 View commit details
    Browse the repository at this point in the history

  4. Removes 'import type' in so package domain. Updates mocks for find sh… 

    …ared origin objects and find legacy url aliases tests to remove reference to repository mock. Refactor of scoped client provider getExensions.
    @jeramysoucy
    jeramysoucy committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    7f8214f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'refactor-update_object_spaces' of https://github.com/Ti… 

    …naHeiligers/kibana into merge-saved-objects-extensions
    @jeramysoucy
    jeramysoucy committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    507250f View commit details
    Browse the repository at this point in the history

  6. Reverting removal of import type

    @jeramysoucy
    jeramysoucy committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    d604293 View commit details
    Browse the repository at this point in the history

  7. Fixes lost update to point-in-time finder mock.

    @jeramysoucy
    jeramysoucy committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    9ed2d02 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. import type housekeeping

    @jeramysoucy
    jeramysoucy committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    bd0695b View commit details
    Browse the repository at this point in the history

  2. Adds exports for extention ID's from core/server to replace static in… 

    …-line strings.
    @jeramysoucy
    jeramysoucy committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e72c6ad View commit details
    Browse the repository at this point in the history

  3. Renames add_Extension functions to set_Extension

    @jeramysoucy
    jeramysoucy committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    bca7189 View commit details
    Browse the repository at this point in the history

  4. Adds base extension factory and undefined consistency to extension fa… 

    …ctories.
    @jeramysoucy
    jeramysoucy committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    8627b0f View commit details
    Browse the repository at this point in the history

  5. Adds enxtensions folder. Adds duplicate local extensions mock. Genera… 

    …l housekeeping.
    @jeramysoucy
    jeramysoucy committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    1df2e31 View commit details
    Browse the repository at this point in the history

  6. [CI] Auto-commit changed files from 'node scripts/precommit_hook.js -… 

    …-ref HEAD~1..HEAD --fix'
    @kibanamachine
    kibanamachine committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    eb39e38 View commit details
    Browse the repository at this point in the history

  7. Fixes factory definitions.

    @jeramysoucy
    jeramysoucy committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f7dfda0 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'refactor-update_object_spaces' of https://github.com/Ti… 

    …naHeiligers/kibana into merge-saved-objects-extensions
    @jeramysoucy
    jeramysoucy committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5edf4ed View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f63f535 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Nov 7, 2022
    Configuration menu
    Copy the full SHA
    7ca4adc View commit details
    Browse the repository at this point in the history

  2. Changes imports for extension ID's to exports from packages. Removes … 

    …re-export of extension ID's.
    @jeramysoucy
    jeramysoucy committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1af7416 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refactor-update_object_spaces' of https://github.com/Ti… 

    …naHeiligers/kibana into merge-saved-objects-extensions
    @jeramysoucy
    jeramysoucy committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    810878d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Adds unit tests for extension set methods of saved objects service.

    @jeramysoucy
    jeramysoucy committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    bd1a1a5 View commit details
    Browse the repository at this point in the history

  2. [CI] Auto-commit changed files from 'node scripts/precommit_hook.js -… 

    …-ref HEAD~1..HEAD --fix'
    @kibanamachine
    kibanamachine committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    f146f2a View commit details
    Browse the repository at this point in the history

  3. Updates checkConflicts comment, removes unused imports in service uni… 

    …t tests.
    @jeramysoucy
    jeramysoucy committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    7e4d8c2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refactor-update_object_spaces' of https://github.com/Ti… 

    …naHeiligers/kibana into merge-saved-objects-extensions
    @jeramysoucy
    jeramysoucy committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4b083a1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    6647ac9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    243bfaa View commit details
    Browse the repository at this point in the history

  2. Refactor getAvailableSpaces in bulkGet to remove redundant null check.

    @jeramysoucy
    jeramysoucy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    3229e46 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refactor-update_object_spaces' of https://github.com/Ti… 

    …naHeiligers/kibana into merge-saved-objects-extensions
    @jeramysoucy
    jeramysoucy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    db77463 View commit details
    Browse the repository at this point in the history

  4. Adds public types to core entry point exports.

    @jeramysoucy
    jeramysoucy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    7f41316 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Update packages/core/saved-objects/core-saved-objects-api-server/src/… 

    …saved_objects_client.ts

Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
    @jeramysoucy @azasypkin
    jeramysoucy and azasypkin authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    31b8532 View commit details
    Browse the repository at this point in the history

  2. Refactors getExtensions of the scoped client provider, and CheckAutho… 

    …rizationParams interface to use Sets for actions.
    @jeramysoucy
    jeramysoucy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    f05c8b6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    7678f71 View commit details
    Browse the repository at this point in the history

  4. Fixes unit tests for check auth expected actions.

    @jeramysoucy
    jeramysoucy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    c9b25b0 View commit details
    Browse the repository at this point in the history

  5. Fixes collect multi-namespace refs unit tests.

    @jeramysoucy
    jeramysoucy committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    ae02c50 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into refactor-update_object_spaces

    @jeramysoucy
    jeramysoucy authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    9909253 View commit details
    Browse the repository at this point in the history